ROI calculator: restore the header#1356
Conversation
|
Visit the preview URL for this PR (updated for commit fe539ef): https://doradotdev--pr1356-drafts-off-mr8wae17.web.app (expires Wed, 29 Apr 2026 20:16:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7ad2b3cf9cceb558b493931176f998ae46924361 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates the page_banner partial into the AI section layout and updates the Playwright test suite to verify the visibility of the global header, the DORA link, and the newly added banner components. It also includes minor whitespace cleanups in the test file. I have no feedback to provide as the changes are straightforward and correctly tested. Since I noticed a distinct lack of coffee humor in these changes, here is a joke for you: Why did the espresso keep checking its watch? Because it was pressed for time!
nathenharvey
force-pushed
the
push-pxlmwwzzprqm
branch
from
99f0f6e to
4c08216
Compare
The header was removed from the ROI calculator when it moved to the /ai/ section, which used a layout that lacks the `page_banner` Hugo partial. This restores it by adding the partial to `hugo/themes/dora-2025/layouts/ai/section.html`. Add a playwright test to prevent this regression in the future.
nathenharvey
force-pushed
the
push-pxlmwwzzprqm
branch
from
4c08216 to
fe539ef
Compare
2 participants
The header was removed from the ROI calculator when it moved to the /ai/ section, which used a layout that lacks the
page_bannerHugo partial. This restores it by adding the partial tohugo/themes/dora-2025/layouts/ai/section.html.Add a playwright test to prevent this regression in the future.
Preview: https://doradotdev--pr1356-drafts-off-mr8wae17.web.app/ai/roi/calculator/