Deduplicate external fragments in typescript-operations#10728
Open
Nurou wants to merge 1 commit intodotansimha:masterfrom
Open
Deduplicate external fragments in typescript-operations#10728Nurou wants to merge 1 commit intodotansimha:masterfrom
Nurou wants to merge 1 commit intodotansimha:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deduplicates
externalFragmentsby name in@graphql-codegen/typescript-operationsbefore they are passed toTypeScriptDocumentsVisitor.Why:
near-operation-filecan supply repeated nestedexternalFragmentstypescript-operationscurrently forwards them as-isThis is related to dotansimha/graphql-code-generator-community#752.
Validation:
externalFragmentsare deduped before visiting documentsyarn workspace @graphql-codegen/typescript-operations vitest run tests/ts-documents.externalFragments.spec.ts tests/ts-documents.externalDocuments.spec.tsLocal benchmark from a downstream repo using
near-operation-file+typescript-operations: