Skip to content

Improve document dedupe logic#10737

Merged
eddeee888 merged 5 commits intomasterfrom
improve-document-dedupe-logic
Apr 18, 2026
Merged

Improve document dedupe logic#10737
eddeee888 merged 5 commits intomasterfrom
improve-document-dedupe-logic

Conversation

@eddeee888
Copy link
Copy Markdown
Collaborator

Description

This PR fixes documents vs externalDocuments dedupe logic.
Previously, we only checked for file hash which means different files with the same content will be deduped and won't be passed on to preset or plugins.

Let's reserve the existing behaviour for preset/plugin integration, such as near-operation-file, for now to avoid making it a breaking change.

Related #10725

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 18, 2026

🦋 Changeset detected

Latest commit: 8071e84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2026

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/cli 6.3.1-alpha-20260418125934-8071e84d4c8fcbddf3ba16aeb3ec38ec02a6f0ec npm ↗︎ unpkg ↗︎

});
});

describe('externalDocuments', () => {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is moved to codegen.config.externalDocuments.spec.ts to keep things isolated and easier to read.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2026

💻 Website Preview

The latest changes are available as preview in: https://pr-10737.graphql-code-generator.pages.dev

@eddeee888 eddeee888 merged commit be85118 into master Apr 18, 2026
20 checks passed
@eddeee888 eddeee888 deleted the improve-document-dedupe-logic branch April 18, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant