feat: Support replacing existing table relations#430
Open
Zirak wants to merge 1 commit intoduckdb:mainfrom
Open
feat: Support replacing existing table relations#430Zirak wants to merge 1 commit intoduckdb:mainfrom
Zirak wants to merge 1 commit intoduckdb:mainfrom
Conversation
`relation.create_view` supports a `replace` flag, which is equivalent to ``` CREATE OR REPLACE VIEW ``` However, there was nothing for the `relation.create`, despite the underlying duckdb binding supporting it. This commit threads the flag through. Note that we've got a confusing case of similar functions, different default values: ``` def create (self, table_name: str, replace: bool = False) def create_view(self, view_name: str, replace: bool = True) ``` While `create_view` defaults to `replace=True`, the regular `create` does not `replace` by default. This is done mostly for backwards compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relation.create_viewsupports areplaceflag, which is equivalent toHowever, there was nothing for the
relation.create, despite the underlying duckdb binding supporting it. This commit threads the flag through.Note that we've got a confusing case of similar functions, different default values:
While
create_viewdefaults toreplace=True, the regularcreatedoes notreplaceby default. This is done mostly for backwards compatibility.