added support for custom elements and namespaces#35
added support for custom elements and namespaces#35dylang merged 12 commits intodylang:masterfrom maxnowack:master
Conversation
|
+1 |
|
Thank you for doing this! I'm currently traveling with my wife in Istanbul, I hope to merge this when I return in a couple days. |
lib/rss.js
Outdated
There was a problem hiding this comment.
Can you change this to:
Object.keys(data.custom_namespaces).forEach(function(name) {
_attr['xmlns:' + name] = data.custom_namespaces[name];
});It's a little more functional-style and there won't be a name variable left behind.
added support for custom elements and namespaces
|
I've merged but I'm about to leave for the airport for an 11-hour flight so I don't want to publish until I'm back on the ground in case there are any problems. |
|
Not to be a bother but any update on publishing this? |
|
I've been developing against this PR w/o issue. I did find a couple of minor documentation issues which I corrected in PR #37. Nothing that would delay publishing this though. |
|
@stuartromanek Thanks for the nuge - I finally published as @rv-kip Thanks for this PR, I've rebuilt the tests using tape, hopefully cleaning them up to make it easier to add new tests. The xml it compares it is now stored in separate xml files that I hope to eventually parse and lint as part of the tests. I'll discuss more in #37. |
|
@dylang Awesome! Thanks! |
resolves #31