Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
cert-gen-idp.ymldisable some container security, since this is only used for local testing.chomds fail otherwiseeclipse-pass.local.yml:Zto volumes to allow for file containers to access mounted directories. No mounted files / dirs visible in the container otherwiseidphealthcheck - not sure about the specifics of this healthcheck, I just needed a test command or else was getting errors on startpass-uiexplicitly sets the container to use the root user, otherwise the nginx server startup command can't be runNot included, but these changes also need to be paired with replacing Docker commands with Podman commands (swap
docker->podman) or aliasing docker keyword to podmanTesting
Need some feedback about these changes, especially when running normally with Docker