Honor expression context when creating Watches#2311
Open
SougandhS wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Honor expression context when creating Watches#2311SougandhS wants to merge 1 commit intoeclipse-platform:masterfrom
SougandhS wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
SougandhS
force-pushed
the
ImproveWatchExp
branch
from
9cd2c8b to
258d31a
Compare
Contributor
SougandhS
force-pushed
the
ImproveWatchExp
branch
2 times, most recently
from
9f1d82f to
94c201a
Compare
SougandhS
force-pushed
the
ImproveWatchExp
branch
3 times, most recently
from
691bfc1 to
ed20f18
Compare
Contributor
Author
|
Hi @merks, could you please check this change when you get a moment ? |
SougandhS
force-pushed
the
ImproveWatchExp
branch
from
ed20f18 to
c5186ad
Compare
SougandhS
force-pushed
the
ImproveWatchExp
branch
from
c5186ad to
e303a5e
Compare
SougandhS
force-pushed
the
ImproveWatchExp
branch
from
e303a5e to
cf11047
Compare
Contributor
Author
|
Hi @iloveeclipse, could you please trigger a co-pilot review for this PR ? |
There was a problem hiding this comment.
Pull request overview
This PR updates watch-expression creation to preserve expression context (e.g., creating myobj.myfield instead of just myfield) when creating Watches via both the Watch command and drag & drop into the Expressions view, addressing evaluation failures (Bug 321289).
Changes:
- Build context-aware expressions for nested selections using
TreeSelection/TreePathin the Watch handler. - Build context-aware expressions for nested selections using
TreeSelection/TreePathin the Expressions view drop adapter. - Minor refactor in
WatchHandlerto split out watch-expression creation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/expression/ExpressionDropAdapter.java |
Updates drag & drop watch-expression generation to use selection paths for contextual expressions. |
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/expressions/WatchHandler.java |
Updates the Watch command to generate contextual expressions from selection paths and refactors watch creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
.../org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/expressions/WatchHandler.java
Outdated
Show resolved
Hide resolved
...clipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/expression/ExpressionDropAdapter.java
Show resolved
Hide resolved
...clipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/expression/ExpressionDropAdapter.java
Show resolved
Hide resolved
...clipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/expression/ExpressionDropAdapter.java
Outdated
Show resolved
Hide resolved
...clipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/expression/ExpressionDropAdapter.java
Outdated
Show resolved
Hide resolved
.../org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/expressions/WatchHandler.java
Show resolved
Hide resolved
.../org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/expressions/WatchHandler.java
Outdated
Show resolved
Hide resolved
SougandhS
force-pushed
the
ImproveWatchExp
branch
2 times, most recently
from
98ab017 to
1417891
Compare
When selecting a field under an object, both the Watch command and Drag & Drop previously created a non-contextual expression using only the field name, which caused evaluation failures. This fix ensures that both Watch and Drag & Drop now generate proper context-aware expressions such as myobj.myfield instead of just the field name. Fixes : https://bugs.eclipse.org/bugs/show_bug.cgi?id=321289
SougandhS
force-pushed
the
ImproveWatchExp
branch
from
1417891 to
19310a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting a field under an object, both the Watch command and Drag & Drop previously created a non-contextual expression using only the field name, which causes evaluation failures. This fix ensures that both Watch and Drag & Drop now generate proper context-aware expressions such as myobj.myfield instead of just the field name.
Fixes : https://bugs.eclipse.org/bugs/show_bug.cgi?id=321289
Before [Watch by context and by drag-drop] :
Before.mp4
After [Watch by context and by drag-drop] :
After.mp4