Skip to content

Interpolate action with proper config parsing and additional metadata support#263

Draft
pgeier wants to merge 2 commits intodevelopfrom
feature/interpolate-additional-metadata-strict
Draft

Interpolate action with proper config parsing and additional metadata support#263
pgeier wants to merge 2 commits intodevelopfrom
feature/interpolate-additional-metadata-strict

Conversation

@pgeier
Copy link
Copy Markdown
Contributor

@pgeier pgeier commented Apr 16, 2026

Description

Alternative PR to handle additional metadata in a strict way. Currently only the keyword "resolution" is allowed.
The action has been reworked to support proper config parsing (util/config). Due to the fact that options are forwarded to MIR, some more caveats have to be taken into account:

There is an option called "options" which contains a LocalConfiguration that is completely forwarded to MIR - this passing through anything which is against the reasons why the config parser was added (to be more specific, which is the reason why the the other PR is discouraged).

On the other hand, the metkit language yaml was loaded and all postprocs keywords are also supported as option. To combine these with the stricter option struct, a typed list of these keywards where copied, yet without validation contents.

Both approaches have their caveats and are redundant to each other - a proper decision should be taken how the action config should be cleaned up.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-263

@pgeier pgeier force-pushed the feature/interpolate-additional-metadata-strict branch 4 times, most recently from 389edaf to 35c1075 Compare April 17, 2026 06:52
@pgeier pgeier force-pushed the feature/interpolate-additional-metadata-strict branch 4 times, most recently from d69e108 to ed9d86e Compare April 17, 2026 11:29
@pgeier pgeier force-pushed the feature/interpolate-additional-metadata-strict branch from ed9d86e to f494fa9 Compare April 17, 2026 11:45
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 53.44828% with 108 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.11%. Comparing base (ca206b5) to head (f494fa9).

Files with missing lines Patch % Lines
src/multio/util/config/detail/Parser.cc 16.12% 52 Missing ⚠️
src/multio/action/interpolate/Interpolate.cc 65.71% 48 Missing ⚠️
src/multio/util/config/detail/Parser.h 55.55% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #263      +/-   ##
===========================================
- Coverage    56.26%   56.11%   -0.16%     
===========================================
  Files          323      322       -1     
  Lines        21140    21219      +79     
  Branches      1687     1695       +8     
===========================================
+ Hits         11894    11906      +12     
- Misses        9246     9313      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants