Interpolate action with proper config parsing and additional metadata support#263
Draft
Interpolate action with proper config parsing and additional metadata support#263
Conversation
389edaf to
35c1075
Compare
d69e108 to
ed9d86e
Compare
ed9d86e to
f494fa9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #263 +/- ##
===========================================
- Coverage 56.26% 56.11% -0.16%
===========================================
Files 323 322 -1
Lines 21140 21219 +79
Branches 1687 1695 +8
===========================================
+ Hits 11894 11906 +12
- Misses 9246 9313 +67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative PR to handle additional metadata in a strict way. Currently only the keyword "resolution" is allowed.
The action has been reworked to support proper config parsing (util/config). Due to the fact that options are forwarded to MIR, some more caveats have to be taken into account:
There is an option called "options" which contains a LocalConfiguration that is completely forwarded to MIR - this passing through anything which is against the reasons why the config parser was added (to be more specific, which is the reason why the the other PR is discouraged).
On the other hand, the metkit language yaml was loaded and all postprocs keywords are also supported as option. To combine these with the stricter option struct, a typed list of these keywards where copied, yet without validation contents.
Both approaches have their caveats and are redundant to each other - a proper decision should be taken how the action config should be cleaned up.
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-263