Skip to content

ampctl trace improvements#2002

Merged
leoyvens merged 5 commits intomainfrom
leo/ampctl-improvements
Mar 20, 2026
Merged

ampctl trace improvements#2002
leoyvens merged 5 commits intomainfrom
leo/ampctl-improvements

Conversation

@leoyvens
Copy link
Collaborator

A few improvements from testing ampctl trace:

  1. Add some instrumentation for the footer cache
  2. Filter spans on the client to avoid receiving pre-truncated responses

Also fix some AI nonsense:
4. Move all logic into ampctl crate instead of having a separate trace-report crate
5. Stop printing the whole span tree to stdout

@leoyvens leoyvens force-pushed the leo/ampctl-improvements branch from 13b0f2a to a4c950e Compare March 20, 2026 17:24
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoyvens leoyvens merged commit fdf9841 into main Mar 20, 2026
8 checks passed
@leoyvens leoyvens deleted the leo/ampctl-improvements branch March 20, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants