Alternate backport of demos update#3317
Draft
chrisdennis wants to merge 2 commits intoehcache:release/3.11from
Draft
Alternate backport of demos update#3317chrisdennis wants to merge 2 commits intoehcache:release/3.11from
chrisdennis wants to merge 2 commits intoehcache:release/3.11from
Conversation
…) and add slf4j exclusions on Terracotta dependencies (statistics, offheap-store, sizeof, terracotta-utilities-tools) that declare the conflicting 1.7 range - Fix Java deprecation/removal warnings treated as errors by -Werror - Add missing javax.xml.bind:jaxb-api to xjcToolJakarta configuration to fix ClassNotFoundException during Jakarta XJC code generation - Add javadocAdd/jakartaJavadocAdd classpath configurations in ehcache/build.gradle (spotbugs-annotations, jaxb-api) and clustered/ehcache-clustered/build.gradle (ehcache-common-api, ehcache-common) required for javadocJar tasks in the assemble chain - Backport of TDB-19854 (master/3.12): upgrade SpotBugs to 4.9.8, AssertJ to 3.27.7, Mockito to 5.12.0, ByteBuddy to 1.18.3; rewrite demos to use embedded Jetty 12 instead of Gretty; refactor SPI tests to use JUnit 4 rules; update Mockito 5 API usage (MockitoAnnotations, ArgumentMatchers); fix SpotBugs annotation usages - Address compilation errors and test failures introduced by upgrading slf4j from 1.7.x to 2.0.17 - PR build with java 17 - Fix async assertion (implemented manually since awaitility is not present)
Contributor
aurbroszniowski
left a comment
aurbroszniowski
left a comment
There was a problem hiding this comment.
The PR makes sense, just a couple of points:
- Shouldn't we keep the @SuppressWarnings from my PR? It wouldn't have a negative impact and would get rid of compilation errors (not blocking in java 8 but blocking for someone who wants to compile with java 17)
- same for the deprecation fix in my PR about newInstance(); replaced by .getDeclaredConstructor().newInstance()
- Also shouldn't we keep the expectException
helper inSPIStoreTester from my PR? It doesn't impact negatively the build, and makes the test code more readable
| @@ -0,0 +1,55 @@ | |||
| /* | |||
| * Copyright Terracotta, Inc. | |||
| * Copyright IBM Corp. 2024, 2025 | |||
Contributor
There was a problem hiding this comment.
do we need to move this to 2026 now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.