Skip to content

Fixed macro calling#984

Merged
NoyaArie merged 1 commit intomasterfrom
fix-upload-artifacts-method
Apr 14, 2026
Merged

Fixed macro calling#984
NoyaArie merged 1 commit intomasterfrom
fix-upload-artifacts-method

Conversation

@ofek1weiss
Copy link
Copy Markdown
Contributor

@ofek1weiss ofek1weiss commented Apr 14, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved artifact upload strategy resolution to ensure correct handling of table artifacts during data operations.

@github-actions
Copy link
Copy Markdown
Contributor

👋 @ofek1weiss
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1fbf7758-c2dc-4796-9b0b-4a1fed3577ad

📥 Commits

Reviewing files that changed from the base of the PR and between afa2383 and b168acd.

📒 Files selected for processing (1)
  • macros/edr/dbt_artifacts/upload_artifacts_to_table.sql

📝 Walkthrough

Walkthrough

The upload_artifacts_to_table.sql macro now explicitly qualifies a function call to elementary.get_upload_artifact_method() using the namespace prefix instead of an unqualified reference, ensuring proper function resolution when determining artifact upload strategy.

Changes

Cohort / File(s) Summary
Namespace Qualification
macros/edr/dbt_artifacts/upload_artifacts_to_table.sql
Updated get_upload_artifact_method() call to use explicit elementary. namespace prefix for proper function resolution in the append logic branch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰✨ A hop, a skip, a namespace so clear,
We qualify functions without any fear,
Elementary, my dear, the path is now bright,
One little dot makes the resolution right! 🎯

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fixed macro calling' is vague and does not clearly convey the specific change made to the macro namespace resolution. Consider a more descriptive title such as 'Use elementary namespace for upload_artifact_method macro' to clearly indicate the specific fix applied.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-upload-artifacts-method

Comment @coderabbitai help to get the list of available commands and usage tips.

@NoyaArie NoyaArie merged commit a37f020 into master Apr 14, 2026
28 checks passed
@NoyaArie NoyaArie deleted the fix-upload-artifacts-method branch April 14, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants