[libc] Add ppoll stub to match existing pselect stub. NFC#26084
[libc] Add ppoll stub to match existing pselect stub. NFC#26084sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
This is mostly just for consistency and completeness.
…-core#26084) This is mostly just for consistency and completeness.
|
Why are we defining function that won't work at runtime? In the GLib we have a check in |
IIUC, this is how emscripten has worked since its inception. If you don't want the stubs we have a setting to disabled them: https://emscripten.org/docs/tools_reference/settings_reference.html#allow-unimplemented-syscalls |
|
@thiblahute For GLib specifically, you might also be interested in this changeset: This would also remove the need for the performance-unfriendly |
|
@kleisauke You mean GNOME/glib@db7b8c4 or something else? This is not gonna get upstreamed, so I do not think it is an option. Have you measured the overhead of using |
|
For
It's been over six years since I last measured this, so the results may no longer be accurate. Perhaps it was the same issue as observed in PR #26478. |
|
For ppoll specifically, I think we can followup by actually implement ppoll and pselect in emscripten (since we already support poll and select and these are basically the same modulo some signal handling stuff which emscripten doesn't support anyway). I will probably do something very similar to what I did for pipe2 here: #26480 |
Because we don't support true async signals this is safe to do in userspace. Followup to emscripten-core#26084
Because we don't support true async signals this is safe to do in userspace. Followup to emscripten-core#26084
Because we don't support true async signals this is safe to do in userspace. Followup to emscripten-core#26084
Because we don't support true async signals this is safe to do in userspace. Followup to emscripten-core#26084
This is mostly just for consistency and completeness.