feat: Support wildcard in non-trailing positions for rate limit descriptor values#1085
Merged
collin-lee merged 1 commit intoenvoyproxy:mainfrom Mar 12, 2026
Conversation
xuannam230201
force-pushed
the
feat/implement-wildcard-in-middle-part-in-string
branch
2 times, most recently
from
d6ccb80 to
a4ca673
Compare
…iptor values Signed-off-by: Nam Dang <xuannam230201@gmail.com>
xuannam230201
force-pushed
the
feat/implement-wildcard-in-middle-part-in-string
branch
from
a4ca673 to
2386daf
Compare
collin-lee
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptor values support wildcard matching using
*. A single*matches zero or more characters and can appear at any position in the value — trailing, middle, or multiple times in the same pattern.foo*foo,foo1,foobarbarfoo*barfoobar,foo123barfoobar1,1foobarfoo*bar*foobar,foo1barXYZbarfoofoo*bar*bazfoobarbaz,foo1bar2bazfoo1bar2When a descriptor has both an exact value and a wildcard pattern that could both match a request, the exact match always takes precedence.
The metric key for a wildcard match preserves the pattern (e.g.,
domain.key_foo*bar) so that all matching values roll up under the same metric. This behaviour can be changed per descriptor usingvalue_to_metricorshare_threshold.