eip8025: update ProofEvent to match zkboost v0.3.0 API#25
Open
frisitano wants to merge 4 commits intoeth-act:feat/eip8025from
Open
eip8025: update ProofEvent to match zkboost v0.3.0 API#25frisitano wants to merge 4 commits intoeth-act:feat/eip8025from
frisitano wants to merge 4 commits intoeth-act:feat/eip8025from
Conversation
zkboost simplified ProofEvent in sigp#40 (c10219b): the WitnessTimeout and ProofTimeout variants were removed and folded into ProofFailure via a new structured `reason: FailureReason` field (WitnessTimeout, ProvingTimeout, ProvingError). - Remove WitnessTimeout and ProofTimeout variants from ProofEvent - Remove ProofEventInfo struct - Add FailureReason enum to types.rs - Add `reason` field to ProofFailure - Update SseEventParts TryFrom to drop the now-gone event names - Update proof_service to log `reason` and drop the timeout match arm Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WitnessTimeoutandProofTimeoutvariants fromProofEvent— these were eliminated in zkboost PR Remove dead code sigp/lighthouse#40 (c10219b)ProofEventInfostruct (no longer needed)FailureReasonenum (WitnessTimeout,ProvingTimeout,ProvingError) matching the upstream zkboost typereason: FailureReasonfield toProofFailureto carry the structured failure reasonSseEventPartsTryFrom to only handleproof_complete/proof_failureevent namesproof_serviceto logreasonand drop the now-removed timeout match armTest plan
cargo check -p execution_layer -p validator_servicespassesproof_engine_zkboostintegration tests pass against the real zkboost server (master branch, post-PR Remove dead code sigp/lighthouse#40)🤖 Generated with Claude Code