fix: let links inside a comment stay clickable when displayCommentAsIcon is on (#90)#375
Merged
JohnMcLear merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
With \`displayCommentAsIcon: true\` the comment is opened by clicking the icon in the gutter. The inline \`.comment\` span in the pad should then behave like ordinary prose so that links inside commented text remain clickable. The click handler on \`.comment\` was unconditionally popping up a comment modal at the click position, which intercepted every link click and made URLs unreachable (reporter's original symptom in #90). Early-return from the \`.comment\` click handler when \`clientVars.displayCommentAsIcon\` is true. Mouseover preview and the icon-based open flow are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90. With
displayCommentAsIcon: true, the comment is opened by clicking the gutter icon — the inline.commentspan in the pad should behave like ordinary prose so that links inside a commented selection remain clickable. The click handler was popping up the comment modal at the click position regardless, intercepting every link click. Early-return from the handler when icon mode is on; mouseover preview and icon-based open flow are untouched.