Skip to content

fix: 3 bugs found via mutation testing + adversarial tests#34

Merged
haasonsaas merged 1 commit intomainfrom
fix/mutation-testing-bugs
Mar 11, 2026
Merged

fix: 3 bugs found via mutation testing + adversarial tests#34
haasonsaas merged 1 commit intomainfrom
fix/mutation-testing-bugs

Conversation

@haasonsaas
Copy link
Collaborator

@haasonsaas haasonsaas commented Mar 11, 2026

Summary

  • Compression bug: Zero token budget and all-deletion-only diffs fell through to Stage 3/4 instead of returning early — could produce incorrect batches when budget is exhausted
  • JSON parser bug: LLM findings silently dropped when line numbers returned as strings ("42") instead of integers (42) — common with some model outputs
  • Added ~55 adversarial edge-case tests covering mutation testing gaps across compression, triage, verification, and LLM response parsing

Test plan

  • All 777 tests pass (cargo test)
  • cargo clippy -- -D warnings clean
  • cargo fmt clean
  • Mutation testing identified the gaps; new tests cover them
  • CI pipeline passes

🤖 Generated with Claude Code


Open with Devin

Bugs fixed:
- compression: zero token budget and all-deletion-only diffs fell through
  to Stage 3/4 instead of returning early when no diffs fit the budget
- llm_response: JSON parser silently dropped findings when LLMs returned
  line numbers as strings ("42") instead of integers (42)

New tests cover mutation testing gaps and adversarial edge cases across
compression, triage, verification, and LLM response parsing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@haasonsaas haasonsaas merged commit 45e0b97 into main Mar 11, 2026
6 checks passed
@haasonsaas haasonsaas deleted the fix/mutation-testing-bugs branch March 11, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant