fix: use max_completion_tokens for Azure OpenAI#760
fix: use max_completion_tokens for Azure OpenAI#760zerone0x wants to merge 2 commits intoevalstate:mainfrom
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
This was made with |
Triage resultHuman attention: Quick readThis PR appears ready for human landing review. It fixes the Azure OpenAI request-shaping bug at the right seam, the bug was locally reproduced and shown fixed, a small test-strengthening follow-up was added, Codex review is clear, CI is green, and the branch is conflict-free against IntentMake Azure OpenAI requests work by sending the token limit under Azure’s expected field name and add a test so this provider-specific behavior is covered. Why
Codex review
CI/CD
Recommendation🏁 Escalate to a human for the final landing decision. The change is small, targeted, validated, reviewed, and conflict-free, so this looks ready for normal human merge judgment. |
Triage resultHuman attention: Quick readThis PR is addressing a real Azure OpenAI compatibility issue: some Azure deployments reject IntentMake fast-agent work with Azure OpenAI by sending the token limit under the parameter name Azure expects, and add a test to lock that behavior in. WhyThe issue report describes 400 errors from Azure OpenAI when Codex reviewThe code change is right-shaped and includes a unit test that asserts the Azure request payload uses CI/CDValidation could not be completed in this handoff because I could not execute the focused repro or test run in this environment. No conflict issues were detected in the merge state. Recommendation🏁 escalate to a human |
Summary
Fixes #461
Testing