Skip to content

Restore DA migration checksum compatibility#36

Merged
pthmas merged 1 commit intomainfrom
pthmas/fix-migration-hash
Mar 19, 2026
Merged

Restore DA migration checksum compatibility#36
pthmas merged 1 commit intomainfrom
pthmas/fix-migration-hash

Conversation

@pthmas
Copy link
Collaborator

@pthmas pthmas commented Mar 19, 2026

Summary

  • restore 20240108000001_block_da_status.sql to its original content so databases that already applied it pass sqlx checksum validation again
  • keep the schema unchanged and fix only the historical migration drift causing atlas-server startup to fail on prod

Testing

  • cargo test --workspace

Summary by CodeRabbit

  • Documentation
    • Updated configuration documentation to clarify environment requirements for block DA status tracking.

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

Updated the SQL migration comment for block_da_status population condition, changing the reference from ENABLE_DA_TRACKING=true to EVNODE_URL configuration requirement. No schema, constraints, indexes, or executable logic were modified.

Changes

Cohort / File(s) Summary
SQL Migration Documentation
backend/migrations/20240108000001_block_da_status.sql
Updated comment documentation clarifying the condition for populating block_da_status: changed from ENABLE_DA_TRACKING=true to requiring EVNODE_URL configuration, while maintaining reference to DA worker requirement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A comment was tweaked, oh how clear,
DA tracking's condition now shines here,
From one flag to another it flew,
EVNODE_URL points the way true! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of the PR—restoring a migration file to its original content to fix checksum compatibility issues that cause production failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pthmas/fix-migration-hash
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@backend/migrations/20240108000001_block_da_status.sql`:
- Line 2: Update the migration comment for block_da_status to accurately state
the gating condition: mention that population occurs only when
ENABLE_DA_TRACKING=true and that EVNODE_URL must be set when that feature is
enabled; reference the DA worker behavior (spawn background DA worker that
queries ev-node for Celestia inclusion heights per block and pushes updates via
broadcast::Sender<Vec<DaSseUpdate>>) to clarify the relationship between
ENABLE_DA_TRACKING and EVNODE_URL rather than implying EVNODE_URL alone is
sufficient.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 21d9bb66-fcf4-41b6-a353-7dd3bf6eb11c

📥 Commits

Reviewing files that changed from the base of the PR and between d95dd59 and 290540e.

📒 Files selected for processing (1)
  • backend/migrations/20240108000001_block_da_status.sql

@pthmas pthmas merged commit 2fb2426 into main Mar 19, 2026
8 checks passed
@pthmas pthmas deleted the pthmas/fix-migration-hash branch March 19, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant