Skip to content

refactor: replace context.WithCancel with t.Context #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 2 commits into from
Mar 20, 2026
Merged

refactor: replace context.WithCancel with t.Context #3183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70d2a0b
refactor: replace context.WithCancel with t.Context
stringsbuilder Mar 20, 2026
8454c65
Merge branch 'main' into main
julienrbrt Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions block/internal/da/async_block_retriever_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ func TestAsyncBlockRetriever_SubscriptionDrivenCaching(t *testing.T) {
logger := zerolog.Nop()
fetcher := NewAsyncBlockRetriever(client, logger, fiNs, 200*time.Millisecond, 100, 5)

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
ctx := t.Context()
fetcher.Start(ctx)
defer fetcher.Stop()

Expand Down Expand Up @@ -128,8 +127,7 @@ func TestAsyncBlockRetriever_CatchupFillsGaps(t *testing.T) {
logger := zerolog.Nop()
fetcher := NewAsyncBlockRetriever(client, logger, fiNs, 100*time.Millisecond, 100, 10)

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
ctx := t.Context()
fetcher.Start(ctx)
defer fetcher.Stop()

Expand Down Expand Up @@ -198,8 +196,7 @@ func TestAsyncBlockRetriever_StopGracefully(t *testing.T) {
logger := zerolog.Nop()
fetcher := NewAsyncBlockRetriever(client, logger, fiNs, 100*time.Millisecond, 100, 10)

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
ctx := t.Context()
fetcher.Start(ctx)
time.Sleep(100 * time.Millisecond)

Expand Down Expand Up @@ -240,8 +237,7 @@ func TestAsyncBlockRetriever_ReconnectOnSubscriptionError(t *testing.T) {
// Very short backoff so reconnect is fast in tests.
fetcher := NewAsyncBlockRetriever(client, logger, fiNs, 50*time.Millisecond, 100, 5)

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
ctx := t.Context()
fetcher.Start(ctx)
defer fetcher.Stop()

Expand Down
Loading