Skip to content

feat: add Hungarian translations#936

Open
urbalazs wants to merge 1 commit intoexecutablebooks:mainfrom
urbalazs:hun-20260318
Open

feat: add Hungarian translations#936
urbalazs wants to merge 1 commit intoexecutablebooks:mainfrom
urbalazs:hun-20260318

Conversation

@urbalazs
Copy link

Added Hungarian translations and sorted existing translations in alphabetical order.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bunch of suggestions, most of the translations look good, but one or two may be off depending on the context. Also, I think we should drop all the : to be more consistent with the other languages, and may also want to have everything capitalized? (I'm not sure about that one).

Also, unrelated nitpick: please don't mix new features with restructuring and other unrelated stylistic changes in the same commit or even in the same PR. It would have been easier to review without all the reordering.

{ "language": "German", "symbol": "de", "text": "Bis zum" },
{ "language": "Greek", "symbol": "el", "text": "Από το" },
{ "language": "Hebrew", "symbol": "iw", "text": "דרך" },
{ "language": "Hungarian", "symbol": "hu", "text": "Szerző:" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ "language": "Hungarian", "symbol": "hu", "text": "Szerző:" },
{ "language": "Hungarian", "symbol": "hu", "text": "Szerző" },

{ "language": "German", "symbol": "de", "text": "Durch" },
{ "language": "Greek", "symbol": "el", "text": "Με" },
{ "language": "Hebrew", "symbol": "iw", "text": "על ידי" },
{ "language": "Hungarian", "symbol": "hu", "text": "Szerző:" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ "language": "Hungarian", "symbol": "hu", "text": "Szerző:" },
{ "language": "Hungarian", "symbol": "hu", "text": "Szerző" },

{ "language": "German", "symbol": "de", "text": "Zuletzt aktualisiert am" },
{ "language": "Greek", "symbol": "el", "text": "Τελευταία ενημέρωση στις" },
{ "language": "Hebrew", "symbol": "iw", "text": "עודכן לאחרונה ב" },
{ "language": "Hungarian", "symbol": "hu", "text": "Utoljára frissítve:" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ "language": "Hungarian", "symbol": "hu", "text": "Utoljára frissítve:" },
{ "language": "Hungarian", "symbol": "hu", "text": "Utoljára frissítve" },

{ "language": "German", "symbol": "de", "text": "Nächste Seite" },
{ "language": "Greek", "symbol": "el", "text": "επόμενη σελίδα" },
{ "language": "Hebrew", "symbol": "iw", "text": "עמוד הבא" },
{ "language": "Hungarian", "symbol": "hu", "text": "következő oldal" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where this is used, but I think we should capitalize to make it more consistent with the other ones.

Suggested change
{ "language": "Hungarian", "symbol": "hu", "text": "következő oldal" },
{ "language": "Hungarian", "symbol": "hu", "text": "Következő oldal" },

{ "language": "German", "symbol": "de", "text": "Öffnen Sie ein Problem" },
{ "language": "Greek", "symbol": "el", "text": "Ανοίξτε ένα ζήτημα" },
{ "language": "Hebrew", "symbol": "iw", "text": "פתח גיליון" },
{ "language": "Hungarian", "symbol": "hu", "text": "Problémajegy nyitása" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

{ "language": "German", "symbol": "de", "text": "offenes Thema" },
{ "language": "Greek", "symbol": "el", "text": "ανοιχτό ζήτημα" },
{ "language": "Hebrew", "symbol": "iw", "text": "בעיה פתוחה" },
{ "language": "Hungarian", "symbol": "hu", "text": "nyitott probléma" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be the same as the previous, I suspect it being used in the "open an issue" context; though maybe we should double check

{ "language": "German", "symbol": "de", "text": "Repository" },
{ "language": "Greek", "symbol": "el", "text": "αποθήκη" },
{ "language": "Hebrew", "symbol": "iw", "text": "מאגר" },
{ "language": "Hungarian", "symbol": "hu", "text": "tároló" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tényleg "github tároló" a magyar forditas?

{ "language": "German", "symbol": "de", "text": "Quell-Repository" },
{ "language": "Greek", "symbol": "el", "text": "Αποθήκη πηγής" },
{ "language": "Hebrew", "symbol": "iw", "text": "מאגר המקורות" },
{ "language": "Hungarian", "symbol": "hu", "text": "Forrástároló" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make it more explicit?

Suggested change
{ "language": "Hungarian", "symbol": "hu", "text": "Forrástároló" },
{ "language": "Hungarian", "symbol": "hu", "text": "Forráskód-tároló" },

{ "language": "German", "symbol": "de", "text": "Sphinx-Buch-Thema" },
{ "language": "Greek", "symbol": "el", "text": "Θέμα βιβλίου Sphinx" },
{ "language": "Hebrew", "symbol": "iw", "text": "נושא ספר ספינקס" },
{ "language": "Hungarian", "symbol": "hu", "text": "Sphinx könyvtéma" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nem inkább könyvminta vagy könyvsablon ?

{ "language": "German", "symbol": "de", "text": "Thema von der" },
{ "language": "Greek", "symbol": "el", "text": "Θέμα από το" },
{ "language": "Hebrew", "symbol": "iw", "text": "נושא מאת" },
{ "language": "Hungarian", "symbol": "hu", "text": "Téma készítője:" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ "language": "Hungarian", "symbol": "hu", "text": "Téma készítője:" },
{ "language": "Hungarian", "symbol": "hu", "text": "Téma készítője" },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants