🏗️ Architect: Centralize NotFoundError across GET Endpoint Mixins#806
🏗️ Architect: Centralize NotFoundError across GET Endpoint Mixins#806
Conversation
…idations Replaced raw `ValueError` raised by `_validate_get_result` in `FilterGetEndpointMixin` and `_raise_not_found` in `PathGetEndpointMixin` and `JobsEndpoint` with the centralized `NotFoundError` from `imednet.errors.api`. Updated all affected test cases to reflect this change. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🏗️ Design Change:
Replaced generic
ValueErrorexceptions with customNotFoundErrors fromimednet.errors.apiacross API get request mixins (FilterGetEndpointMixin,PathGetEndpointMixin) and specific endpoint overrides (JobsEndpoint).♻️ DRY Gains:
Ensures a single, consistent Exception path (
NotFoundError) for all single-item retrieval failures across the entire SDK.🛡️ Solidity:
Enhances API robustness and adheres to the established exception hierarchy, preventing leaky abstractions where users would have had to catch base Python
ValueErrors rather than specificImednetErrorderivatives.Clients who strictly caught
ValueErrorspecifically for "Not Found" logic on.get()methods will now need to catchNotFoundError(or the baseApiError/ImednetError).PR created automatically by Jules for task 12475786350183174156 started by @fderuiter