Skip to content

🏗️ Architect: Centralize NotFoundError across GET Endpoint Mixins#806

Closed
fderuiter wants to merge 1 commit intomainfrom
jules-architect-notfounderror-refactor-12475786350183174156
Closed

🏗️ Architect: Centralize NotFoundError across GET Endpoint Mixins#806
fderuiter wants to merge 1 commit intomainfrom
jules-architect-notfounderror-refactor-12475786350183174156

Conversation

@fderuiter
Copy link
Copy Markdown
Owner

🏗️ Design Change:

Replaced generic ValueError exceptions with custom NotFoundErrors from imednet.errors.api across API get request mixins (FilterGetEndpointMixin, PathGetEndpointMixin) and specific endpoint overrides (JobsEndpoint).

♻️ DRY Gains:

Ensures a single, consistent Exception path (NotFoundError) for all single-item retrieval failures across the entire SDK.

🛡️ Solidity:

Enhances API robustness and adheres to the established exception hierarchy, preventing leaky abstractions where users would have had to catch base Python ValueErrors rather than specific ImednetError derivatives.

⚠️ Breaking Changes:

Clients who strictly caught ValueError specifically for "Not Found" logic on .get() methods will now need to catch NotFoundError (or the base ApiError/ImednetError).


PR created automatically by Jules for task 12475786350183174156 started by @fderuiter

…idations

Replaced raw `ValueError` raised by `_validate_get_result` in `FilterGetEndpointMixin` and `_raise_not_found` in `PathGetEndpointMixin` and `JobsEndpoint` with the centralized `NotFoundError` from `imednet.errors.api`. Updated all affected test cases to reflect this change.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@fderuiter fderuiter closed this Apr 17, 2026
@fderuiter fderuiter deleted the jules-architect-notfounderror-refactor-12475786350183174156 branch April 17, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant