Skip to content

feat(cli): add docs.yml setting to disable environment editing#15111

Open
kafkas wants to merge 4 commits intomainfrom
anar/fer-9706-close-docs-add-option-to-disable-hostname-editability-in
Open

feat(cli): add docs.yml setting to disable environment editing#15111
kafkas wants to merge 4 commits intomainfrom
anar/fer-9706-close-docs-add-option-to-disable-hostname-editability-in

Conversation

@kafkas
Copy link
Copy Markdown
Member

@kafkas kafkas commented Apr 17, 2026

Description

Linear ticket: Refs FER-9706

Adds a new settings.disable-environment-editing option to docs.yml. When enabled, API reference pages can display the configured base URL without allowing users to double-click and edit it, while preserving the current editable behavior by default for backward compatibility.

Changes Made

  • Added disable-environment-editing to the docs.yml schema and regenerated the docs config artifacts
  • Parsed the new setting into the CLI's docs configuration output
  • Added an unreleased changelog entry for the new docs.yml feature

Testing

  • Unit tests added/updated
  • Manual testing completed

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions
Copy link
Copy Markdown
Contributor

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

@github-actions
Copy link
Copy Markdown
Contributor

SDK Generation Benchmark Results

Comparing PR branch against latest nightly baseline on main (2026-04-17T04:58:39Z).

Full benchmark table (click to expand)
Generator Spec main (generator) main (E2E) PR (generator) Delta
csharp-sdk square 98s 141s 43s -55s (-56.1%)
go-sdk square 114s 148s 52s -62s (-54.4%)
java-sdk square 170s 187s 104s -66s (-38.8%)
php-sdk square 99s 127s 42s -57s (-57.6%)
python-sdk square 114s 152s 64s -50s (-43.9%)
ruby-sdk-v2 square 102s 156s 69s -33s (-32.4%)
rust-sdk square 98s 94s 45s -53s (-54.1%)
swift-sdk square 84s 130s 40s -44s (-52.4%)
ts-sdk square 100s 138s 52s -48s (-48.0%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-04-17T04:58:39Z). Trigger benchmark-baseline to refresh.
Last updated: 2026-04-17 12:41 UTC

@github-actions
Copy link
Copy Markdown
Contributor

Docs Generation Benchmark Results

Comparing PR branch against latest nightly baseline on main (2026-04-17T04:58:39Z).

Fixture main PR Delta
docs 289.7s 340.0s (35 versions) +50.3s (+17.4%)

Docs generation runs fern generate --docs --preview end-to-end against the benchmark fixture with 35 API versions (each version: markdown processing + OpenAPI-to-IR + FDR upload).
Delta is computed against the nightly baseline on main.
Baseline from nightly run(s) on main (latest: 2026-04-17T04:58:39Z). Trigger benchmark-baseline to refresh.
Last updated: 2026-04-17 12:44 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants