release: Add the scripts to publish to az marketplace#3812
release: Add the scripts to publish to az marketplace#3812sayanchowdhury wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
| -e AZ_SECRET_VALUE="${AZ_SECRET_VALUE}" \ | ||
| -v "${PWD}"/ci-automation/release/azure_marketplace_publish.py:/app/azure_marketplace_publish.py \ | ||
| -w /app \ | ||
| ghcr.io/astral-sh/uv:alpine \ |
There was a problem hiding this comment.
Should this be something to mirror on our ghcr?
There was a problem hiding this comment.
Here I'm directly using the uv package from that of astral-sh - works fine in Jenkins.
There was a problem hiding this comment.
Here I'm wondering mostly about mirroring ghcr.io/astral-sh/uv:alpine on Flatcar as, say, ghcr.io/flatcar/uv. We do something like that for some docker images that we use in kola tests.
| if not args.test_mode and plan not in ("alpha", "beta", "stable", "lts2022", "lts2023", "lts2024"): | ||
| logging.error("plan value should be either alpha, beta, stable, lts2024, lts2023 or lts2022") |
There was a problem hiding this comment.
Probably would be nicer to get the lts list from the lts-info file.
There was a problem hiding this comment.
updated to pull the channels from channel-info file
| logging.error("Required: AZ_TENANT_ID, AZ_CLIENT_ID, AZ_SECRET_VALUE") | ||
| return | ||
|
|
||
| access_token = generate_partner_center_token(tenant_id, client_id, secret_value) |
There was a problem hiding this comment.
Does this generate a new access token every time or returns the same thing? If the former, should we destroy those after publishing?
There was a problem hiding this comment.
Yes, this token gets generated everytime we run the script - and this is not stored on disk anywhere.
There was a problem hiding this comment.
Right, I was mostly wondering if information about those tokens is stored somewhere on Azure, so at some point we hit a limit of generated tokens or something, because we didn't remove them or something.
There was a problem hiding this comment.
No, we won't hit limit. Since this is used only for release - at max we would be generating 4-5 tokens in every few days.
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
github-project-automation
bot
moved this to ⚒️ In Progress
in Flatcar tactical, release planning, and roadmap
Co-authored-by: Krzesimir Nowak <knowak@microsoft.com>
sayanchowdhury
requested a deployment
to
development
GitHub Actions
Waiting
2 participants
Add Azure marketplace publishing to Jenkins pipeline to load the items into draft.
To be merged with https://github.com/flatcar/jenkins-os/pull/417