[wip] automate the capi image building and publishing#959
[wip] automate the capi image building and publishing#959sayanchowdhury wants to merge 2 commits intomainfrom
Conversation
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
| _=" | ||
| ${AZURE_CLIENT_ID} | ||
| ${AZURE_CLIENT_SECRET} | ||
| " |
There was a problem hiding this comment.
If we don't require them as env vars, we can remove this
There was a problem hiding this comment.
If you want to also support usage through manual invocation, you can move this to the else case of the block below.
| # Use of this source code is governed by a BSD-style license that can be | ||
| # found in the LICENSE file. | ||
|
|
||
| # >>> This file is supposed to be SOURCED from the repository ROOT. <<< |
There was a problem hiding this comment.
If we don't really need sourcing, we can simplify this and expect the script to be invoked directly. Sourcing always modifies shared global state and is hard to reason about.
| if sig-image-version-exists; then | ||
| return | ||
| fi |
There was a problem hiding this comment.
This is not the wanted behavior when we have to rerun the release step. It should replace/republish.
| if sig-image-version-exists; then | ||
| return | ||
| fi |
There was a problem hiding this comment.
This is not the wanted behavior when we have to rerun the release step. It should replace/republish.
| } | ||
|
|
||
| function _capi_image_build_impl() { | ||
| local arch="$1" |
There was a problem hiding this comment.
For the high level entry point maybe let's not require the architecture to be passed from the jenkins job where it would have to have a for loop. Either this script here can build and publish arm64 or it can't because the feature is missing.
sayanchowdhury
force-pushed
the
sayan/capi-automation
branch
from
c55899b to
5a4e4a4
Compare
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
sayanchowdhury
force-pushed
the
sayan/capi-automation
branch
from
68ff299 to
ceb90c9
Compare
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
sayanchowdhury
force-pushed
the
sayan/capi-automation
branch
from
ceb90c9 to
af602dc
Compare
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
sayanchowdhury
force-pushed
the
sayan/capi-automation
branch
from
af602dc to
15f4a4c
Compare
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
sayanchowdhury
force-pushed
the
sayan/capi-automation
branch
from
15f4a4c to
9b33762
Compare
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Failure
|
|
||
|
|
||
| for elem in parsed_data.get('schedules', []): | ||
| print(elem.get('next').get('release')) |
There was a problem hiding this comment.
This should filter out releases with a target in the future. The yaml entry looks like that: targetDate: 2023-07-12
sayanchowdhury
force-pushed
the
sayan/capi-automation
branch
from
9b33762 to
86c1559
Compare
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
sayanchowdhury
force-pushed
the
sayan/capi-automation
branch
from
86c1559 to
19a5fb8
Compare
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Error
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Failure
|
Hey guys, Im just trying to clean up some old PRs and Issues. @pothos @sayanchowdhury Can we close this PR? |
|
Let's close this PR as the recommended way is to use sysext. |
3 participants
This is a WIP PR, not yet tested.
ref flatcar/Flatcar#1104