Skip to content

feat: use fetch for Flyte API HTTP client#898

Merged
ursucarina merged 7 commits intomasterfrom
carina/dropaxios
Mar 31, 2026
Merged

feat: use fetch for Flyte API HTTP client#898
ursucarina merged 7 commits intomasterfrom
carina/dropaxios

Conversation

@ursucarina
Copy link
Copy Markdown
Contributor

@ursucarina ursucarina commented Mar 31, 2026

TL;DR

Malicious publishes were reported for affected axios versions on npm; see axios#10604 and Step Security’s write-up. Moving HTTP calls to native fetch removes reliance on axios for those code paths and shrinks the vulnerable surface

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Switches Flyte console API traffic from axios to the native fetch API

Changes

  • flyte-api: defaultFetchConfig / getFetchApiCall (and related helpers); request errors normalized via transformRequestError.
  • common: HttpRequestError and proto/response decoding tweaks as needed for the new path.
  • oss-console: HTTP client wiring (axiosClient / data layer), hooks and models that performed GETs (useUserProfile, api.ts, admin paths), and error UI boundaries aligned with the new error shape.

Tracking Issue

n/a

Signed-off-by: Carina Ursu <carina@union.ai>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 45.39007% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.61%. Comparing base (2e69321) to head (7aadf78).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/flyte-api/src/utils/defaultFetchConfig.ts 0.00% 27 Missing ⚠️
...es/oss-console/src/components/data/fetchClient.tsx 61.90% 24 Missing ⚠️
packages/flyte-api/src/utils/getFetchApiCall.ts 0.00% 9 Missing ⚠️
...oss-console/src/components/Errors/ErrorHandler.tsx 20.00% 4 Missing ⚠️
.../oss-console/src/models/AdminEntity/AdminEntity.ts 55.55% 4 Missing ⚠️
...-console/src/components/data/loadChunkWithAuth.tsx 0.00% 2 Missing ⚠️
...kages/flyte-api/src/utils/transformRequestError.ts 50.00% 1 Missing ⚠️
...nDetails/NodeExecutionTabs/NodeExecutionInputs.tsx 50.00% 1 Missing ⚠️
...Details/NodeExecutionTabs/NodeExecutionOutputs.tsx 50.00% 1 Missing ⚠️
.../components/Launch/LaunchForm/ResumeSignalForm.tsx 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #898   +/-   ##
=======================================
  Coverage   54.61%   54.61%           
=======================================
  Files         585      585           
  Lines       15325    15390   +65     
  Branches     2804     2831   +27     
=======================================
+ Hits         8369     8405   +36     
- Misses       6956     6985   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina merged commit 9d77ba9 into master Mar 31, 2026
11 of 12 checks passed
@ursucarina ursucarina deleted the carina/dropaxios branch March 31, 2026 17:10
@flyte-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants