fix(render): use theme selection color instead of hardcoded default#280
Merged
forketyfork merged 3 commits intomainfrom Apr 13, 2026
Merged
fix(render): use theme selection color instead of hardcoded default#280forketyfork merged 3 commits intomainfrom
forketyfork merged 3 commits intomainfrom
Conversation
The selection highlight in the terminal renderer was hardcoded to RGB(27, 34, 48) — the default selection color — ignoring the user's configured theme.selection color entirely. The entire theme pipeline was correctly wired (config parsing, Theme struct, parameter passing) but the renderer bypassed it with a magic constant. https://claude.ai/code/session_01LEMeiusgjjsdom3xchh5Kh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terminal renderer was still hardcoding the default selection color (
RGB(27, 34, 48)) instead of usingtheme.selection, so custom themes showed the wrong selection highlight.While checking for the same mistake elsewhere, I found one more match in the worktree creation modal: its input field was still pinned to fixed One Dark-style colors. This PR now routes that input fill, border, and placeholder text through the active theme as well.
It also adds a small regression test around the derived modal input style and updates the configuration docs to make the theme coverage explicit.
Checks:
zig buildzig build testjust linthttps://claude.ai/code/session_01LEMeiusgjjsdom3xchh5Kh