Revert "Revert "Horrible fix for cross site badness""#506
Revert "Revert "Horrible fix for cross site badness""#506georgelgeback wants to merge 1 commit intomainfrom
Conversation
This reverts commit acda2b9.
|
I’m confused, do you want to revert the reverted fix? I thought the regex fix was ok? |
|
I'm gonna take a guess and say that its because you can't put in a list and a regex? Haven't tried the code though so idk |
|
I'm not sure why but I know trying to run the frontend against the stage backend with the regex did not work. Best explanation I have is that regex is treated in the same way as the wildcard and doesn't change how cookies are allowed. |
|
Does it work locally? The problem was with localhost CORS, no? |
|
Backend was on stage, frontend was local when I tested. This is the only setup where it didn't work and we wanted it to. |
|
I still think this solution is unsatisfying, and I think we should eventually try to use regex, but if we really need this now, I’ll approve on the condition that the the issue remains open |
|
We don't super need this now, we can wait a few weeks until we figure out a good solution. |
HellFelix
left a comment
There was a problem hiding this comment.
Approving on the condition that this is fixed later!
|
Your call |
Reverts #503
Reason: I pushed the current solution to stage, tested it and it did not work.
If any other solution can be found that would be great. I also strongly dislike this fix.