fix(musicSearch): replace broken request-promise with native fetch#2
Open
garrettwinder wants to merge 1 commit intomasterfrom
Open
fix(musicSearch): replace broken request-promise with native fetch#2garrettwinder wants to merge 1 commit intomasterfrom
garrettwinder wants to merge 1 commit intomasterfrom
Conversation
The request-promise dependency is pinned to ^0.0.1, a long-abandoned
package whose main field points to a missing lib/tp.js, causing
node server.js to crash at startup via require-dir. Replace the three
request() call sites with a small local httpGet helper built on Node's
built-in fetch, preserving the {url, json, headers} option shape so the
existing .then((res) => ...) chains remain behaviorally identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request-promiseis pinned to^0.0.1, a long-abandoned package whosemainfield points to a missinglib/tp.js, causingnode server.jsto crash at startup vialib/helpers/require-dir.js(which requires every file underlib/actions).request()call sites inlib/actions/musicSearch.jswith a small localhttpGethelper built on Node's built-infetch(Node 25). No new dependency.{url, json, headers}option shape so.then((res) => ...)chains remain behaviorally identical (resis text or parsed JSON, exactly asrequest-promisereturned).Test plan
node -e "require('./lib/actions/musicSearch.js'); console.log('require OK')"passesnode server.jsboots, logshttp server listening on 0.0.0.0 port 5005, no exceptions in logGET /zonesreturns HTTP 200 with a zones array (live Sonos hardware present during test)Note:
request-promiseis intentionally left inpackage.jsonas dead weight for a follow-up cleanup, per task instructions.Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com