feat: news-summary v4 — 教育+投資分析ブリーフィング skill#740
Open
tomoki0603 wants to merge 8 commits intogarrytan:mainfrom
Open
feat: news-summary v4 — 教育+投資分析ブリーフィング skill#740tomoki0603 wants to merge 8 commits intogarrytan:mainfrom
tomoki0603 wants to merge 8 commits intogarrytan:mainfrom
Conversation
Full redesign from v2 single-file to structured Obsidian knowledge base. Layer design (speed briefing + education callouts), stock notes with 自分のメモ protection, living glossary, weekly summaries, Chart.js candlestick charts, Chrome MCP integration for paid content access. Adversarial review fixes: JST timezone, | in filename sanitization, news entry idempotency check for stock notes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CSO audit findings: - Remove mcp__Claude_in_Chrome__computer from allowed-tools. The skill only needs read-only Chrome MCP tools (navigate, get_page_text, read_page, find). computer allows clicks/typing which contradicts the read-only safety intent. - Replace hardcoded Obsidian vault path with OBSIDIAN_VAULT env var (falls back to default). Add VAULT_NOT_FOUND detection with AskUserQuestion prompt for first-run configuration.
5 gaps identified in CEO review of first execution output: - Add indicator retry logic (2 attempts before marking 要確認) - Require stock notes for ALL high+medium impact stocks (min 5/run) - Prohibit empty file creation (0-byte glossary files) - Set minimum depth for low-impact educational callouts (2-3 lines) - Add completeness check: if >3 indicators missing, retry before output
Stock notes were skeleton-only (sector + market, everything else "未取得"). Now the template: - Adds 6 financial metrics to basic info (price, market cap, PER, PBR, dividend yield, 52-week range) with WebSearch retrieval instruction - Adds "今日のポイント" section for per-stock investment analysis - Updates Step 8-B to refresh price and daily analysis on each run - Changes 四季報 fallback text from "未取得" to actionable next-step
…g, state file) - Extract Chart.js candlestick template to templates/candlestick.html - Add parallel collection groups for Step 2 data gathering - Add unified error handling rules table - Add glossary list to Step 0 for accurate wikilinks - Add specific URLs for auxiliary sources (Step 2-E) - Remove hardcoded stock note minimum count - Add Friday afternoon auto-verification for weekly predictions - Add .state.json session state file for cross-session tracking
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full redesign of
/news-summaryfrom v2 (single-file output) to a structured Obsidian knowledge base with layered education.Core feature (5 commits):
## 自分のメモ)templates/candlestick.htmlTemplate improvements (1 commit):
Preamble cleanup (merged from prior commits):
"${_TEL:-off}"prevents writing when unsetTest Coverage
613 pass, 15 fail (all pre-existing Windows platform issues: CRLF, binary compat)
Pre-Landing Review
Pre-Landing Review: 2 informational issues
PR Quality Score: 9/10
Test plan
🤖 Generated with Claude Code