fix: check AAAA records in DNS rebinding protection (IPv6 bypass)#742
Open
Gonzih wants to merge 1 commit intogarrytan:mainfrom
Open
fix: check AAAA records in DNS rebinding protection (IPv6 bypass)#742Gonzih wants to merge 1 commit intogarrytan:mainfrom
Gonzih wants to merge 1 commit intogarrytan:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
resolvesToBlockedIp()inbrowse/src/url-validation.tsonly callsresolve4()— it only checks IPv4 A records. An attacker can bypass the DNS rebinding protection by setting up a hostname that has only an AAAA (IPv6) record pointing to a cloud metadata endpoint (or an IPv6 equivalent). Closes #668.Example bypass: a domain with only
AAAA ::ffff:169.254.169.254(IPv4-mapped IPv6) would sail right through the existing check.Fix
resolve6()alongsideresolve4()— both run concurrently viaPromise.allSettled::ffff:169.254.169.254andfe80::1toBLOCKED_METADATA_HOSTSto catch IPv4-mapped and link-local IPv6 metadata patternsPromise.allSettledso a failure on one record type doesn't prevent checking the otherWhy
Promise.allSettlednotPromise.allMany hosts legitimately have no AAAA records.
resolve6()throwsENOTFOUNDin those cases. UsingallSettledcollects both results and lets us check all resolved addresses without a try/catch per record type.sent from mStack