fix: chmod 1777 /tmp not chmod -R 1777 /tmp in Dockerfile.ci#747
Open
Gonzih wants to merge 1 commit intogarrytan:mainfrom
Open
fix: chmod 1777 /tmp not chmod -R 1777 /tmp in Dockerfile.ci#747Gonzih wants to merge 1 commit intogarrytan:mainfrom
Gonzih wants to merge 1 commit intogarrytan:mainfrom
Conversation
chmod -R 1777 /tmp sets the sticky bit on every FILE inside /tmp, not just on the directory itself. The sticky bit on files has no modern use and causes misbehavior in some tools that check permissions. The sticky bit on /tmp the directory (1777) is correct and intentional. The recursive -R flag is wrong and was also run twice redundantly. Fix: remove -R, keep chmod 1777 /tmp once, drop the duplicate. Closes garrytan#709
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bug
`Dockerfile.ci` has:
```dockerfile
&& chmod 1777 /tmp \ ← correct
&& chmod -R 1777 /tmp ← wrong + duplicate
```
`chmod -R 1777 /tmp` recursively sets the sticky bit on every file inside `/tmp`, not just the directory. The sticky bit on a directory (1777) is well-defined: it prevents users from deleting each other's files. The sticky bit on a file has no defined behavior in modern Linux/POSIX and can confuse tools that inspect permissions (e.g., package managers, installers, security scanners that report "unexpected sticky bit on file").
It also runs twice — the first `chmod 1777 /tmp` on the line before is correct. The second with `-R` undoes that correctness.
Issue #709.
Fix
Remove the recursive `-R` flag and deduplicate. One `chmod 1777 /tmp` is correct.
sent from mStack