feat: add hallucination check requirement for rag#712
feat: add hallucination check requirement for rag#712akihikokuroda wants to merge 4 commits intogenerative-computing:mainfrom
Conversation
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
| # for helper functions. | ||
|
|
||
| backend = LocalHFBackend(model_id="ibm-granite/granite-3.3-8b-instruct") | ||
| # Force CPU usage by creating custom config |
There was a problem hiding this comment.
out of curiosity, why are we forcing this to the cpu?
There was a problem hiding this comment.
I had problems running this example on my Mac. I can take out this change from this PR.
| ) -> float: | ||
| ) -> list[dict]: |
There was a problem hiding this comment.
good catch -- looks like the return type didn't match the docstring before.
wonder how come mypy didn't catch this?
There was a problem hiding this comment.
I don't know, either.
There was a problem hiding this comment.
I wonder if we may want to consolidate some of the new examples (?)
There was a problem hiding this comment.
It may be better. We probably have more examples here so 3 files for one function seems too much.
2 participants
Misc PR
Type of PR
Description
Testing