feat(dashboard): add widget add, edit, and delete commands#407
Draft
betegon wants to merge 2 commits intofeat/dashboard-commands-corefrom
Draft
feat(dashboard): add widget add, edit, and delete commands#407betegon wants to merge 2 commits intofeat/dashboard-commands-corefrom
betegon wants to merge 2 commits intofeat/dashboard-commands-corefrom
Conversation
9 tasks
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Dashboard
Init
Issue List
Other
Bug Fixes 🐛Init
Other
Internal Changes 🔧Init
Other
Other
🤖 This preview updates automatically when you update the PR. |
02c23d0 to
f05f91a
Compare
17da821 to
64ddb86
Compare
Contributor
Codecov Results 📊✅ 104 passed | Total: 104 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 89.00%. Project has 781 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 96.68% 96.44% -0.24%
==========================================
Files 159 170 +11
Lines 21011 21924 +913
Branches 0 0 —
==========================================
+ Hits 20314 21143 +829
- Misses 697 781 +84
- Partials 0 0 —Generated by Codecov Action |
2a0361d to
38e3eda
Compare
Add three widget management subcommands under `sentry dashboard widget`: - `widget add` — add a widget with inline --display/--query/--where/--group-by flags - `widget edit` — edit an existing widget by --index or --title, merging only changed fields - `widget delete` — remove a widget by --index or --title All widget commands use GET-modify-PUT pattern with server field stripping and auto-layout for new widgets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…o shared module - Move resolveWidgetIndex from edit.ts to resolve.ts (shared by edit + delete) - Extract validateWidgetEnums to resolve.ts (shared by add + edit) - Remove inline enum validation from add.ts and edit.ts - Remove inline widget-index logic from delete.ts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1f3a700 to
0d179ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry dashboard widget add— add a widget with inline--display/--query/--where/--group-by/--sort/--limitflagssentry dashboard widget edit— edit an existing widget by--indexor--title, merging only changed fieldssentry dashboard widget delete— remove a widget by--indexor--titleformatWidgetAdded,formatWidgetDeleted,formatWidgetEdited)All widget commands use the GET-modify-PUT pattern with server field stripping and auto-layout for new widgets.
Stacked on #406.
Test plan
bun run typecheck— no new type errorsbun run lint— passesbun test test/types/dashboard.test.ts— 53 tests pass🤖 Generated with Claude Code