test(native): eliminate sleeps and restarts#1619
Merged
Conversation
Use httpserver.wait() context managers and expect_oneshot_request() instead of time.sleep() + restart patterns for more reliable and faster test execution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mujacica
approved these changes
Apr 1, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
JoshuaMoelans
approved these changes
Apr 1, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Use
httpserver.wait()context managers andexpect_oneshot_request()instead oftime.sleep(2)+ restart patterns for more reliable and faster test execution.In busy CI environments, crash processing might exceed 2s. In a fast local development environment, however, it often doesn't take more than a few hundred milliseconds, so unconditional 2s sleeps unnecessarily slow down the test execution.
httpserver.wait(timeout=10)combined withexpect_oneshot_request()is perfect because it only waits the time it actually takes to receive the request, while being flexible up to 10s if necessary in busy CI environments.Also, the daemon has a 10s shutdown timeout, which should be enough to flush envelopes in tests, meaning the restarts should not be necessary (famous last words?)
sentry-native/src/backends/native/sentry_crash_context.h
Lines 95 to 96 in 72e1d42
Before,
pytest tests/test_integration_native.pytook roughly 45s on my Mac. With this, it takes less than 10s.