fix(transport): handle WinHttpReceiveResponse failure#1620
Merged
Conversation
WinHttpReceiveResponse failure (e.g. connection reset after successful send) was silently ignored, causing the status code to default to 0. The SDK treated this as a successful send, so the envelope was neither retried nor cached — silently lost. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace hardcoded unreachable DSN (127.0.0.1:19999) with a session- scoped fixture that runs a TCP server accepting and immediately resetting connections. This gives the SDK an instant connection failure instead of waiting ~2s for WinHTTP to timeout on a closed port. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mujacica
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WinHttpReceiveResponsefailures (e.g. on connection reset) were silently ignored, causing the status code to default to 0. The SDK treated this as a successful send, so when that failure was hit, the envelope was not correctly retried or cached.The issue was exposed while adding
unreachable_dsnpytest fixture that uses TCP RST for instant connection failures, replacing the hardcoded unreachable "127.0.0.1:19999" DSN that caused ~2s WinHTTP timeouts per test on Windows. The test changes are included as they expose the bug. As a bonus, they also speed up such retry and cache tests on Windows that require an unreachable DSN.