fix: Map trilogy database adapter to mysql for Query Insights compatibility#2656
Merged
sl0thentr0py merged 3 commits intogetsentry:masterfrom Mar 9, 2026
Merged
fix: Map trilogy database adapter to mysql for Query Insights compatibility#2656sl0thentr0py merged 3 commits intogetsentry:masterfrom
trilogy database adapter to mysql for Query Insights compatibility#2656sl0thentr0py merged 3 commits intogetsentry:masterfrom
Conversation
whitemerry
approved these changes
Jun 24, 2025
krzysztofjablonski
approved these changes
Jun 24, 2025
trilogy database adapter to mysql for Query Insights compatibilitytrilogy database adapter to mysql for Query Insights compatibility
sl0thentr0py
approved these changes
Mar 9, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2656 +/- ##
==========================================
+ Coverage 90.13% 90.35% +0.21%
==========================================
Files 132 141 +9
Lines 5301 5587 +286
==========================================
+ Hits 4778 5048 +270
- Misses 523 539 +16
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
trilogyadapter in Rails app, Query Insights view in Sentry did not show any data.The problem is that
trilogyis not in the allowed system db name list:https://github.com/getsentry/semantic-conventions/blob/main/docs/attributes-registry/db.md
despite being just a different MySQL adapter, and hence does not meet the criteria for span eligibility:
https://docs.sentry.io/product/insights/backend/queries/#span-eligibility
The simple fix is to just map
trilogytomysqlfor the db system name.Current Behavior
No query data is displayed because
trilogyis not recognized as a valid database system.Expected Behavior
Query data from
trilogyadapter should appear in Sentry's Query Insights view, similar to other MySQL adapters.Alternative solution (how I tested it worked)
The same result can be achieved using
before_send_transaction: