Java: generalise javax.persistence models to also recognise jakarta.persistence.#19187
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- java/ql/lib/semmle/code/java/deadcode/DeadField.qll: Language not supported
- java/ql/lib/semmle/code/java/deadcode/EntryPoints.qll: Language not supported
- java/ql/lib/semmle/code/java/frameworks/javaee/Persistence.qll: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jcogs33
left a comment
jcogs33
left a comment
There was a problem hiding this comment.
A couple qldocs need to be updated. LGTM otherwise.
Co-authored-by: Jami <57204504+jcogs33@users.noreply.github.com>
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
LGTM with one small caveat: Did you do any local perf/join-order checking? This sort of change might shift some join-orders.
|
I hadn't; I'll do a DCA now to cross-check. I've made a special-purpose suite consisting of some repos that use javax.persistence and some that use jakarta.persistence, since none in the default DCA suite do, which could hide a problematic join behind a zero result in a sentinel predicate. |
No description provided.