fix(python): honor auto_restart on process exit#797
fix(python): honor auto_restart on process exit#797haosenwang1018 wants to merge 1 commit intogithub:mainfrom
Conversation
|
Thanks for propsing this. However, this feature has never actually worked across any of the languages - there's non-implemented options for it on Python and Go, and then on TypeScript it tries to restart in certain cases but there are many cases where it won't work. The feature dates back to the original spike of this SDK. I think we'd be better off removing it until we can make a more solid implementation, and of course only in reaction to real-world evidence of the need that can provide a clear case for what specifically should be supported. I appreciate the PR you've added here makes it a little closer to working on Python, but it still won't work in a lot of cases (e.g., the CLI subprocess becomes frozen, or it was launched externally in the first place). |
Summary
auto_restartis actually honoredCopilotSessionobjects wired to the refreshed transport after reconnectTesting
Closes #789.