fix: prevent race conditions by creating new objects for repository configurations

[John15321]

Summary

Fixes a race condition where repository.name could leak between repos during concurrent processing, and prevents name from appearing in dry-run diffs when not explicitly configured.

Problem

1. Race condition: Object.assign(repoConfig, {...}) mutates the shared this.config.repository object. When updateRepos() processes multiple repos concurrently via Promise.all, one repo's name can overwrite another's between async yields.

2. Spurious diffs: name always appears in dry-run diffs because Safe-Settings injects it internally but it's not in ignorableFields.

Changes

• lib/settings.js: Use Object.assign({}, repoConfig, {...}) to create new objects instead of mutating shared references
• lib/plugins/repository.js: Add 'name' to ignorableFields to hide it from diffs unless explicitly configured for renaming

Testing

All 112 unit tests pass.

Related to #944

[John15321]

Just fyi, I am not a JS developer at all, so this code analysis and fix was aided by AI, therefore please approach this code with skepticism, but the actual problem we are facing when trying to use safe-settings remains

[Copilot]

Pull request overview

This PR fixes a race condition in lib/settings.js where concurrent processing of repositories via Promise.all could cause name and org to leak between repos due to mutation of the shared this.config.repository object. It also adds 'name' to ignorableFields in lib/plugins/repository.js to suppress spurious diffs in dry-run mode.

Changes:

• lib/settings.js: Replace Object.assign(repoConfig, {...}) with Object.assign({}, repoConfig, {...}) in two places to create new objects instead of mutating shared configuration references.
• lib/plugins/repository.js: Add 'name' to the ignorableFields array to hide it from dry-run diffs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
lib/settings.js	Fix race condition by creating new objects for repoConfig and suborgRepoConfig instead of mutating shared references.
lib/plugins/repository.js	Add 'name' to ignorableFields to suppress it from diff comparisons.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[John15321]

Hi @decyjphr could you please take a look at this PR?