binding_generator: include core/version.hpp in core/defs.hpp

[60k41p]

TypedDictionary fails to compile due to include-order dependency

This fixes use of undeclared identifier 'set_typed' in typed_dictionary.hpp when dictionary.hpp is also included.

Fixes a compile failure where TypedDictionary may report set_typed as undeclared depending on include order. The generated dictionary.hpp uses GODOT_VERSION_MINOR but did not include core/version.hpp, causing the preprocessor guard around set_typed to evaluate before version macros were defined.

This patch updates the generator so Dictionary headers always include godot_cpp/core/version.hpp before version-gated declarations.

This patch adds an include for version.hpp in defs.hpp as a general fix to this & similar potential problems.

Minimal reproducer

File: test/repro_typed_dictionary_include_order.cpp

#include <godot_cpp/variant/dictionary.hpp>
#include <godot_cpp/variant/typed_dictionary.hpp>

#include <godot_cpp/variant/string.hpp>
#include <godot_cpp/variant/variant.hpp>

int main() {
    godot::TypedDictionary<godot::String, godot::Variant> configuration;
    return static_cast<int>(configuration.size());
}

Compile command (from godot-cpp repo root):

g++ -std=c++17 -Iinclude -Igen/include -c test/repro_typed_dictionary_include_order.cpp

Fixes #1942

[dsnopek]

Thanks!

I wonder if we should include version.hpp in defs.hpp? It feels like it fits with the other stuff in defs.hpp, but it's generated so it needs to be its own file. And given how much we use the version macros (and will probably use them more in the future), it makes sense to me to have them everywhere

[60k41p]

Thanks!

I wonder if we should include version.hpp in defs.hpp? It feels like it fits with the other stuff in defs.hpp, but it's generated so it needs to be its own file. And given how much we use the version macros (and will probably use them more in the future), it makes sense to me to have them everywhere

Make sense to me. I've pushed the update.

The __has_include (C++ 17) prevents errors / red squiggles in the IDE until it is generated.

[dsnopek]

Thanks! Looks good to me

[dsnopek]

Ah, sorry, I just noticed this has multiple commits. Can you squash your PR into a single commit?

[60k41p]

Ah, sorry, I just noticed this has multiple commits. Can you squash your PR into a single commit?

Done. The presence of a merge commit pulled into my fork made things non-trivial when rebasing but it's sorted now.

BTW it's possible adjust the repo settings to only allow squashed merging of PRs where Github does the commit squashing automatically.

[mrtripie]

Thank you!