feat(gooddata-sdk): add CSV upload support for GDSTORAGE data sources#1410
Merged
hkad98 merged 2 commits intogooddata:masterfrom Mar 13, 2026
Merged
feat(gooddata-sdk): add CSV upload support for GDSTORAGE data sources#1410hkad98 merged 2 commits intogooddata:masterfrom
hkad98 merged 2 commits intogooddata:masterfrom
Conversation
The OpenAPI Generator regeneration in e47faf7 introduced a pyproject.toml for gooddata-api-client. Since tbump has no entry for this file, uv build picks up the unbumped version from pyproject.toml instead of the bumped VERSION in setup.py, producing a wheel whose version already exists on PyPI. Remove the file so the build continues to use setup.py as the sole version source, matching the tbump configuration. jira: TRIVIAL risk: nonprod
Refresh the lockfile so gooddata-api-client dependencies are resolved from setup.py instead of the removed pyproject.toml. jira: TRIVIAL risk: nonprod
no23reason
approved these changes
Mar 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1410 +/- ##
=======================================
Coverage 77.45% 77.45%
=======================================
Files 225 225
Lines 14661 14661
=======================================
Hits 11355 11355
Misses 3306 3306 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gooddata-api-clientwith theresultOpenAPI spec, bringing typed endpoints and models for CSV staging upload, CSV analysis, CSV import, file listing, file deletion, and CSV file manifest readingupload_csvmethod toCatalogDataSourceServicethat handles end-to-end CSV upload: staging upload, CSV analysis, and CSV import into a GDSTORAGE data source\\x00) inrest.pythat was dropped by OpenAPI Generator during regenerationpyproject.tomlfromgooddata-api-clientto fix dev release version bumping (tbump has no entry for it, causinguv buildto use the unbumped version)