Resolved The app icon set AppIcon has an unassigned child warning…#348
Open
cho407 wants to merge 5 commits intogoogle:mainfrom
Open
Resolved The app icon set AppIcon has an unassigned child warning…#348cho407 wants to merge 5 commits intogoogle:mainfrom
cho407 wants to merge 5 commits intogoogle:mainfrom
Conversation
… by replacing the Mac icon image in the 'AppIcon' asset set.
Contributor
|
Thank you for this contribution! If you could update your branch and ensure you've accepted the CLA, we'd be happy to get this one in :) |
Author
|
I have updated the branch and accepted the CLA. Thanks for your comment |
w-goog
approved these changes
Mar 11, 2026
cho407
changed the title
Author
|
Thanks for the approval. I realized after updating the branch that the double quotes in the PR title could have caused an issue with the JSON payload for the Google Chat notification workflow. I’ve updated the PR title, but I’m not entirely sure whether the change was reflected properly. I’d appreciate it if you could approve it again. Hope you have a great day:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the sample code, I noticed the warning 'The app icon set "AppIcon" has an unassigned child'. Concerned that this might undermine the integrity of the example, I made a minor adjustment. I found that a 1024x1024 size Mac icon was unassigned, so I moved it to the correct size slot. If my modification is appropriate, I kindly request a merge. Have a great day! :)