Add Swarming service for Remote Task Gate#5206
Conversation
6adf5ef to
241f5b6
Compare
0033ed9 to
a54d1d5
Compare
017887b to
9702d8d
Compare
9702d8d to
7200eda
Compare
9da970f to
615788e
Compare
Co-authored-by: Diego Jardon <37823380+jardondiego@users.noreply.github.com>
2917cf7 to
b79d077
Compare
45274e8 to
150e132
Compare
javanlacerda
left a comment
There was a problem hiding this comment.
Overall looks good, and I think we can merge it once some minor fixes are addressed, and then we can make the other adjustments in the following PRs.
We just need to be sure that the changes will not have any side effect in prod.
| if len(remote_tasks) == 1: | ||
| unscheduled_tasks = [] | ||
|
|
||
| if feature_flags.FeatureFlags.SWARMING_REMOTE_EXECUTION.enabled: |
There was a problem hiding this comment.
I think we could keep this function cleaner if we could move this logic to an auxiliary function.
There was a problem hiding this comment.
I am not sure I see an auxiliary function with this single line. I guess I probably do not understand very well what would we encapsulate in that auxiliary function. Can you clarify?
There was a problem hiding this comment.
My point here is more to avoid having swarming specific logic into the generic create_utask_main_job.
c78524e to
78a1502
Compare
78a1502 to
d4e44d5
Compare
Add remote task service for Swarming and include it in Remote Task gate logic.
Summary
This PR integrates Swarming as a first-class remote task execution service within the RemoteTaskGate. It introduces the SwarmingService, which encapsulates the logic for pushing uworker main tasks to Swarming, and updates the
RemoteTaskGate to utilize this service for unified task distribution.
Key Changes
swarming.push_swarming_task, providing a standardized interface consistent with Kubernetes and GCP Batch services.
filter and process swarming-eligible tasks and return the remaining tasks for distribution to other backends.