Skip to content

Fix int8 #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 12, 2026
Merged

Fix int8 #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compression/compress-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ struct CompressTraits<int8_t> {
const auto vi32_1 = hn::NearestInt(v1);
const auto vi16 = hn::OrderedDemote2To(di16, vi32_0, vi32_1);
const auto vi8 = hn::OrderedDemote2To(
di8_16, hn::UpperHalf(di16_16, vi16), hn::LowerHalf(di16_16, vi16));
di8_16, hn::LowerHalf(di16_16, vi16), hn::UpperHalf(di16_16, vi16));
hn::StoreU(vi8, di8_16, packed.ptr + packed_ofs + i);
}
}
Expand All @@ -487,7 +487,7 @@ struct CompressTraits<int8_t> {
const auto vi32_1 = hn::NearestInt(v1);
const auto vi16 = hn::OrderedDemote2To(di16, vi32_0, vi32_1);
const auto vi8 = hn::OrderedDemote2To(
di8_16, hn::UpperHalf(di16_16, vi16), hn::LowerHalf(di16_16, vi16));
di8_16, hn::LowerHalf(di16_16, vi16), hn::UpperHalf(di16_16, vi16));
hn::StoreN(vi8, di8_16, packed.ptr + packed_ofs + i, remaining);
}
}
Expand Down
3 changes: 1 addition & 2 deletions gemma/tiled_attention.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,7 @@ static HWY_INLINE void ComputeQKVTransposedTile(
v_cache_values = v_buf;
}

if (attention_impl == AttentionImpl::kFlashTransposedQsBF16 &&
!IsInt8<KV_T>()) {
if (attention_impl == AttentionImpl::kFlashTransposedQsBF16) {
const int in_tile_idx_mod_2 = in_tile_idx % 2;
for (int dim = 0; dim < qkv_dim; dim += 2) {
const int dim_mod_2 = dim % 2;
Expand Down
Loading