Skip to content

[ci] Fix syntax errors in yq and jq#3104

Merged
joshlf merged 1 commit intomainfrom
Gebjymcx3pko5oy6wx4qr4i6er4i3iodm
Mar 10, 2026
Merged

[ci] Fix syntax errors in yq and jq#3104
joshlf merged 1 commit intomainfrom
Gebjymcx3pko5oy6wx4qr4i6er4i3iodm

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Mar 10, 2026


Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v1 Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gebjymcx3pko5oy6wx4qr4i6er4i3iodm && git checkout -b pr-Gebjymcx3pko5oy6wx4qr4i6er4i3iodm FETCH_HEAD

Checkout

git fetch origin refs/heads/Gebjymcx3pko5oy6wx4qr4i6er4i3iodm && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gebjymcx3pko5oy6wx4qr4i6er4i3iodm && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gebjymcx3pko5oy6wx4qr4i6er4i3iodm

Stacked PRs enabled by GHerrit.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses syntax errors in yq and jq commands used within the continuous integration (CI) scripts. These corrections ensure that the CI workflows correctly parse configuration files and metadata, preventing script failures and maintaining the reliability of automated checks.

Highlights

  • yq command fix: The yq command in ci/check_all_toolchains_tested.sh was updated to include the -r (raw output) flag, ensuring correct parsing of YAML output.
  • yq syntax correction: The yq command in ci/check_job_dependencies.sh was modified to use bracket notation (.jobs["all-jobs-succeed"].needs[]) for accessing keys with hyphens, resolving a syntax error.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • ci/check_all_toolchains_tested.sh
    • Added the -r flag to the yq command to ensure raw string output, which is necessary for subsequent grep and sort operations.
  • ci/check_job_dependencies.sh
    • Corrected the yq syntax for accessing the all-jobs-succeed job's needs array by switching from dot notation to bracket notation, accommodating the hyphen in the job name.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@joshlf joshlf requested a review from jswrenn March 10, 2026 00:40
@joshlf joshlf enabled auto-merge March 10, 2026 00:40
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes syntax errors in yq commands within the CI scripts. The change to use raw output with yq -r and to properly quote keys with hyphens are appropriate. I've added one suggestion to improve the shell script style by avoiding an unnecessary cat command, which also offers a minor performance benefit.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (a5f537a) to head (e62a49e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3104   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          20       20           
  Lines        6057     6057           
=======================================
  Hits         5565     5565           
  Misses        492      492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gherrit-pr-id: Gebjymcx3pko5oy6wx4qr4i6er4i3iodm
@joshlf joshlf force-pushed the Gebjymcx3pko5oy6wx4qr4i6er4i3iodm branch from 4993d04 to e62a49e Compare March 10, 2026 00:59
@joshlf joshlf added this pull request to the merge queue Mar 10, 2026
Merged via the queue into main with commit 88ac4f4 Mar 10, 2026
105 checks passed
@joshlf joshlf deleted the Gebjymcx3pko5oy6wx4qr4i6er4i3iodm branch March 10, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants