Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the minimum required versions for several Google Cloud client libraries within the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the minimum required versions for google-cloud-access-context-manager, google-cloud-kms, and google-cloud-os-config. The change is made in the gapic/templates/_pypi_packages.j2 template file to ensure that generated packages use versions that do not have a runtime dependency on setuptools, addressing a ModuleNotFoundError for pkg_resources. The modifications are correct and well-contained within the template data. I have reviewed the changes and found no issues.
Bump the minimum version of
google-cloud-access-context-manager,google-cloud-kmsandgoogle-cloud-os-configto the version which doesn't have a runtime dependency onsetuptoolsto avoid the following error which appears in googleapis/google-cloud-python#16094. See build loghttps://github.com/googleapis/python-access-context-manager/releases/tag/v0.2.0
https://github.com/googleapis/python-kms/releases/tag/v2.13.0
https://github.com/googleapis/python-os-config/releases/tag/v1.13.0