Skip to content

migrate code from googleapis/nodejs-bigtable#7852

Open
GautamSharda wants to merge 958 commits intomainfrom
nodejs-bigtable-migration
Open

migrate code from googleapis/nodejs-bigtable#7852
GautamSharda wants to merge 958 commits intomainfrom
nodejs-bigtable-migration

Conversation

@GautamSharda
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

renovate-bot and others added 30 commits May 3, 2022 00:24
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-bigtable).
* Add third option in app profile config.

* First test

* Fix a test case that broke

* test for error when list is not clusters

* Fix linter errors

* Add a create app profile for an array of clusters

* linting fixes

* Working system test

* Remove unused imports

* linting fix

* Add to license

* Update copyright year

* PR fix 1

* linter fix

* Use a set instead of an array

* Refactor that will make test writing easier

* Second refactor

* Another refactor to shorten the test

* before function is successful

* create instance with clusters

* Make individual test as short as possible

* single and multiple cluster tests

* Added a third test

* test for creating a profile and modifying it

* change a test case message

* Reformatting test cases

* linter fixes

* First PR correction

* PR fixes

* Test for single cluster routing

* A set of clusters

* change test description

* Added capability for an array of strings passed in

* Checks if every element is a string

* Error message update

* linter fix

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* message change

* Fixed regular expression

* Removed unnecessary escape characters.

* Fixed indent

* update a description

* grpc-gpc upgrade

* Use the refactored generateId

* fake cluster and types update

* Changed generate id code fragment

* Revert "Changed generate id code fragment"

This reverts commit 7b862ef9cb4f44cb2b11a149ed99c41696668793.

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
* build!: Update library to use Node 12

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* work in progress - broken

* Add autoscaling options to interface

* Work in progress on function for setting metadata

* Fixed some tests that were broken due to the chang

* Cluster.ts in test file

* Update cluster creation to accept new parameters

* Fix for failing test

* Enhance system tests for cluster

* Add another test

* condense tests

* Added more tests

* Test improvements

* Change update mask to get manual scaling right

* Added validation for cluster creation configs

* Refactor cluster object in tests

* Another cluster id refactor

* Remove TODO that no longer applies

* Code reorganization for test cases

* Fix the test so that it breaks for good reason

* update mask push fix

* Add nodes in all calls to update and create cluste

* Add license headers

* correct copyright year

* Add singlequote

* Add a validation

* Update test descriptions

* refactor to use one check metadata function

* Fix tests as specifying nodes is required anyway

* should added to test case descriptions

* PR updates

* validation error

* Remove call to get metadata

* PR updates
)

Source-Link: googleapis/synthtool@cd78529
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:ddb19a6df6c1fa081bc99fb29658f306dd64668bc26f75d1353b28296f3a78e6
Use gapic-generator-typescript v2.14.5.
PiperOrigin-RevId: 450616838
Source-Link: googleapis/googleapis@7a47b72
Source-Link: googleapis/googleapis-gen@42cc633
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDJjYzYzMzFiYWUwYjk5ZjYxYjhlMDFhZTE1YjA1MjExNzE2YzRmOSJ9
PiperOrigin-RevId: 450372109
Source-Link: googleapis/googleapis@942691f
Source-Link: googleapis/googleapis-gen@609a369
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjA5YTM2OTY2YzQwZjcyNmZkMGRjNzFlOTUzZGM4M2Y4ZTUyZmVmMSJ9
feat: refreshes Bigtable Admin API(s) protos
PiperOrigin-RevId: 448988001
Source-Link: googleapis/googleapis@b6fa58e
Source-Link: googleapis/googleapis-gen@fc8b8db
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmM4YjhkYmM3ZGExYTc4NDVkNTcxMzRmNDExMzAyZDEwNmVhMmVmMiJ9
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* snapshot tests for create cluster

* change request to config

* More snapshot tests

* Refactor constants out

* Add generated testcases for partial cluster update

* Add header to constants file

* Add script to regenerate snapshots

Co-authored-by: Benjamin E. Coe <bencoe@google.com>
* First code samples

* Add the end exclude tag

* Update the comments

* Add integration test for delete code snippets

* Three more test cases

* Add the final test case

* Add header

* linting fix

* Add call options

* Use before instead of beforeEach

* PR updates

* Remove comment that is unimportant

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* remove start exclude and end exclude tags

* row range feedback

* Delete row snapshot

* Slight change to fix samples test

* switch batch delete to batch insert

* Removed line of code that is shortening timestamp

* Correct snapshot

* Revert "Removed line of code that is shortening timestamp"

This reverts commit 96adcdbee42e26e53aa270a43713732342cf902c.

* Fix to short snapshot.

* Revert "Fix to short snapshot."

This reverts commit 73736e694014e0730acba2635186b6659961a610.

* Revert "Correct snapshot"

This reverts commit f86b6fab4207aba417e974d147f3f048a423208f.

* Revert "switch batch delete to batch insert"

This reverts commit 72cef5d5da00041cd09a49d155f05c4402143e3f.

* streaming and batching changes

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* snapshot tests for create cluster

* change request to config

* More snapshot tests

* Refactor constants out

* Add generated testcases for partial cluster update

* Add header to constants file

* Remove need to pass location along

* Remove comment

* eliminate compile error

* lint fix
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
* Getting grpc set up for tests

* test for error sent through gax

* Trying other things

* Group everything into describe blocks.

* Add Google header

* Added more tests

* Create mock service files

* refactor a check

* mock server tests

* undo tests

* Pass metadata through

* build fix

* work in progress

* Add service error check and change test

* Remove TODO and add done hook.

* Logs for debugging

* use the tcp-port-used library instead

* use await

Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [linkinator](https://togithub.com/JustinBeckwith/linkinator) | [`^2.0.3` -> `^4.0.0`](https://renovatebot.com/diffs/npm/linkinator/2.16.2/4.0.0) | [![age](https://badges.renovateapi.com/packages/npm/linkinator/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/linkinator/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/linkinator/4.0.0/compatibility-slim/2.16.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/linkinator/4.0.0/confidence-slim/2.16.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>JustinBeckwith/linkinator</summary>

### [`v4.0.0`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v4.0.0)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.1.0...v4.0.0)

##### Features

-   create new release with notes ([#&#8203;508](https://togithub.com/JustinBeckwith/linkinator/issues/508)) ([2cab633](https://togithub.com/JustinBeckwith/linkinator/commit/2cab633c9659eb10794a4bac06f8b0acdc3e2c0c))

##### BREAKING CHANGES

-   The commits in [#&#8203;507](https://togithub.com/JustinBeckwith/linkinator/issues/507) and [#&#8203;506](https://togithub.com/JustinBeckwith/linkinator/issues/506) both had breaking changes.  They included dropping support for Node.js 12.x and updating the CSV export to be streaming, and to use a new way of writing the CSV file.  This is an empty to commit using the `BREAKING CHANGE` format in the commit message to ensure a release is triggered.

### [`v3.1.0`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.1.0)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.6...v3.1.0)

##### Features

-   allow --skip to be defined multiple times ([#&#8203;399](https://togithub.com/JustinBeckwith/linkinator/issues/399)) ([5ca5a46](https://togithub.com/JustinBeckwith/linkinator/commit/5ca5a461508e688de12e5ae6b4cfb6565f832ebf))

### [`v3.0.6`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.6)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.5...v3.0.6)

##### Bug Fixes

-   **deps:** upgrade node-glob to v8 ([#&#8203;397](https://togithub.com/JustinBeckwith/linkinator/issues/397)) ([d334dc6](https://togithub.com/JustinBeckwith/linkinator/commit/d334dc6734cd7c2b73d7ed3dea0550a6c3072ad5))

### [`v3.0.5`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.5)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.4...v3.0.5)

##### Bug Fixes

-   **deps:** upgrade to htmlparser2 v8.0.1 ([#&#8203;396](https://togithub.com/JustinBeckwith/linkinator/issues/396)) ([ba3b9a8](https://togithub.com/JustinBeckwith/linkinator/commit/ba3b9a8a9b19d39af6ed91790135e833b80c1eb6))

### [`v3.0.4`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.4)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.3...v3.0.4)

##### Bug Fixes

-   **deps:** update dependency gaxios to v5 ([#&#8203;391](https://togithub.com/JustinBeckwith/linkinator/issues/391)) ([48af50e](https://togithub.com/JustinBeckwith/linkinator/commit/48af50e787731204aeb7eff41325c62291311e45))

### [`v3.0.3`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.3)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.2...v3.0.3)

##### Bug Fixes

-   export getConfig from index ([#&#8203;371](https://togithub.com/JustinBeckwith/linkinator/issues/371)) ([0bc0355](https://togithub.com/JustinBeckwith/linkinator/commit/0bc0355c7e2ea457f247e6b52d1577b8c4ecb3a1))

### [`v3.0.2`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.2)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.1...v3.0.2)

##### Bug Fixes

-   allow server root with trailing slash ([#&#8203;370](https://togithub.com/JustinBeckwith/linkinator/issues/370)) ([8adf6b0](https://togithub.com/JustinBeckwith/linkinator/commit/8adf6b025fda250e38461f1cdad40fe08c3b3b7c))

### [`v3.0.1`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.1)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.0...v3.0.1)

##### Bug Fixes

-   decode path parts in local web server ([#&#8203;369](https://togithub.com/JustinBeckwith/linkinator/issues/369)) ([4696a0c](https://togithub.com/JustinBeckwith/linkinator/commit/4696a0c38c341b178ed815f47371fca955979feb))

### [`v3.0.0`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.0)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v2.16.2...v3.0.0)

##### Bug Fixes

-   **deps:** update dependency chalk to v5 ([#&#8203;362](https://togithub.com/JustinBeckwith/linkinator/issues/362)) ([4b17a8d](https://togithub.com/JustinBeckwith/linkinator/commit/4b17a8d87b649eaf813428f8ee6955e1d21dae4f))

-   feat!: convert to es modules, drop node 10 ([#&#8203;359](https://togithub.com/JustinBeckwith/linkinator/issues/359)) ([efee299](https://togithub.com/JustinBeckwith/linkinator/commit/efee299ab8a805accef751eecf8538915a4e7783)), closes [#&#8203;359](https://togithub.com/JustinBeckwith/linkinator/issues/359)

##### BREAKING CHANGES

-   this module now requires node.js 12 and above, and has moved to es modules by default.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-bigtable).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Daniel Bruce <djbruce@google.com>
* First try

* Add after hook

* Proper test done for closed client

* test description change

* Eliminate unnecessary comment

* Modify test to reflect change
* getRanges

* Slight refactor of createReadStream

* Add header to table utils

* Eliminate circular dependency
* snapshot tests for create cluster

* change request to config

* More snapshot tests

* Refactor constants out

* Add generated testcases for partial cluster update

* Add header to constants file

* Remove need to pass location along

* Remove comment

* Use new function to calculate location

* Add space to stay consistent

* Use getClusterBaseConfigWithFullLocation again

* Fix test

* linting fix

* eliminate compile error

* lint fix

* remove the stubs that are not used anymore

* Add an assert statement for location
* Add a logger to print the instance id.

* Add cluster id logging
* fixed the closed client test

* fix: fixed the closed client test
Source-Link: googleapis/synthtool@d229a12
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e
* wait for long running operation on flakey test.

* fix: Wait for long running operation on flakey test
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227
Source-Link: googleapis/synthtool@ab7384e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Comment on lines +24 to +44
runs-on: ubuntu-latest
strategy:
matrix:
node: [ 18, 20 ]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
repository: googleapis/cloud-bigtable-clients-test
ref: main
path: cloud-bigtable-clients-test
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- uses: actions/setup-go@v5
with:
go-version: '>=1.20.2'
- run: chmod +x handwritten/bigtable/.kokoro/conformance.sh
- run: npm install
- run: go version
- run: handwritten/bigtable/.kokoro/conformance.sh

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Comment on lines +24 to +44
runs-on: ubuntu-latest
strategy:
matrix:
node: [ 18, 20 ]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
repository: googleapis/cloud-bigtable-clients-test
ref: v0.0.3
path: cloud-bigtable-clients-test
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- uses: actions/setup-go@v5
with:
go-version: '>=1.20.2'
- run: chmod +x handwritten/bigtable/.kokoro/mandatory-conformance.sh
- run: npm install
- run: go version
- run: handwritten/bigtable/.kokoro/mandatory-conformance.sh

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
}

static createPrefixRange(start: string): PrefixRange {
const prefix = start.replace(new RegExp('[\xff]+$'), '');

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data

This [regular expression](1) that depends on [library input](2) may run slow on strings with many repetitions of '\u00ff'. This [regular expression](1) that depends on [library input](3) may run slow on strings with many repetitions of '\u00ff'. This [regular expression](1) that depends on [library input](4) may run slow on strings with many repetitions of '\u00ff'. This [regular expression](1) that depends on [library input](5) may run slow on strings with many repetitions of '\u00ff'. This [regular expression](1) that depends on [library input](6) may run slow on strings with many repetitions of '\u00ff'.
userOptions: this.options,
},
) as string;
this.qualifiers = this.family![qualifierName] =

Check warning

Code scanning / CodeQL

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](1).
this.projectId,
undefined,
);
Object.assign(clusters[(cluster as ClusterInfo).id!], {

Check warning

Code scanning / CodeQL

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](1).
}

if (family! && qualifierName) {
qualifier = family![qualifierName] = family![qualifierName] || [];

Check warning

Code scanning / CodeQL

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](1).
GautamSharda and others added 23 commits March 24, 2026 20:35
…gle-cloud-node into nodejs-bigtable-migration
…gle-cloud-node into nodejs-bigtable-migration
…gle-cloud-node into nodejs-bigtable-migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet