Skip to content

chore: first pass on cleaning up build warnings#2843

Open
igorbernstein2 wants to merge 11 commits intomainfrom
warnings
Open

chore: first pass on cleaning up build warnings#2843
igorbernstein2 wants to merge 11 commits intomainfrom
warnings

Conversation

@igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Mar 13, 2026

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@igorbernstein2
test: fix tests after junit5 introduction
6c1e9f8 
Change-Id: I07ec31eda18f13cdab34aaed7e55e5c08ea078df

# Conflicts:
#	google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/PreparedStatementImplTest.java
#	google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTestUtils.java
#	google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/sql/ExecuteQueryRetryTest.java
@igorbernstein2
fix warnings
458a892 
Change-Id: Idac85099557a02fa040ef7d8d695c49004a13e89
@igorbernstein2 igorbernstein2 requested review from a team as code owners March 13, 2026 17:56
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Mar 13, 2026
@generated-files-bot
Copy link

generated-files-bot bot commented Mar 13, 2026 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdminImpl.java

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Mar 13, 2026
mutianf
mutianf reviewed Mar 13, 2026
View reviewed changes
igorbernstein2 and others added 7 commits March 13, 2026 15:17
@igorbernstein2
improve view name formating
95a9a3f 
Change-Id: I85e271194cfada199186db271b042eeedf9fd7cf
@igorbernstein2
fix tests & address feedback
55dda42 
Change-Id: I44e660ab37999be0e98f71db3c089df03c123aad
@igorbernstein2
more tweaks
900c134 
Change-Id: Ia1f48d96c0bb2cfd0596629de87c8015c330276d
@cloud-java-bot
chore: generate libraries at Fri Mar 13 19:23:29 UTC 2026
c4cd2bd
@igorbernstein2
more tweaks
c395c8b 
Change-Id: I4f9f1dd6191d2971d95303f9bc939c4d0999c6e7
@igorbernstein2
more tweaks to Type
e3b2bc8 
Change-Id: Ic37e638d362ce976240a978356f7a78662d4e409
@igorbernstein2
improve errorprone config and suppress some warnings in Types
89f2c09 
Change-Id: I6d05d0a2b40c11dc0d3888f97a685f2b698a270d
@igorbernstein2
fix integration test
6a2ef7e 
Change-Id: Iaee7b16aa966aad6409ec6f7aec88fc0e6d59e56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mutianf mutianf mutianf approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2 @mutianf @cloud-java-bot