Open
Conversation
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
size: l
cherylEnkidu
force-pushed
the
cheryl/subquery
branch
from
46ed5ab to
7acdb11
Compare
product-auto-label
bot
added
size: xl
cherylEnkidu
force-pushed
the
cheryl/subquery
branch
from
d504667 to
d0f184a
Compare
product-auto-label
bot
added
size: xl
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: xl
cherylEnkidu
commented
Feb 27, 2026
...le-cloud-firestore/src/main/java/com/google/cloud/firestore/pipeline/stages/DefineStage.java
Outdated
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
...-firestore/src/main/java/com/google/cloud/firestore/pipeline/stages/SubcollectionSource.java
Outdated
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
...-firestore/src/main/java/com/google/cloud/firestore/pipeline/stages/SubcollectionSource.java
Outdated
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Outdated
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Outdated
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Outdated
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Outdated
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Outdated
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITPipelineSubqueryTest.java
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Show resolved
Hide resolved
cherylEnkidu
commented
Feb 27, 2026
...loud-firestore/src/main/java/com/google/cloud/firestore/pipeline/expressions/Expression.java
Show resolved
Hide resolved
dlarocque
reviewed
Mar 25, 2026
Comment on lines
+32
to
+33
| @InternalApi | ||
| public FunctionExpression(String name, List<? extends Expression> params) { |
Contributor
There was a problem hiding this comment.
Why do we make this internal?
Comment on lines
+82
to
+90
| bookDocs = | ||
| ImmutableMap.<String, Map<String, Object>>builder() | ||
| .put( | ||
| "book1", | ||
| ImmutableMap.<String, Object>builder() | ||
| .put("title", "The Hitchhiker's Guide to the Galaxy") | ||
| .put("author", "Douglas Adams") | ||
| .put("genre", "Science Fiction") | ||
| .put("published", 1979) |
Contributor
There was a problem hiding this comment.
It looks like this is a copy of the bookDocs from the ITPipelineTest.java setup. Can you pull this setup code out from both of these places and put it into a function that we can reuse in both places? Maybe we could remove ~150 LOC from here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add support for Pipeline subqueries
This PR introduces support for Pipeline Subqueries, allowing users to perform complex data transformations and aggregations on subcollections within a pipeline.
Key Features
Pipeline.subcollection(String path)to initiate a pipeline on a subcollection of the current document.Pipeline.define(...)to bind values to variables for reuse within the pipeline scope.Expression.currentDocument(): Reference the current document in a pipeline stage.Expression.variable(String name): Access defined variables.Pipeline.toArrayExpression()andPipeline.toScalarExpression(): Convert subquery results into array or scalar expressions for use in parent pipelines.Testing
ITPipelineSubqueryTest.javacontaining integration tests for subquery functionality.