chore: don't use mtls in gcb until b/492452834 is fixed#1769
chore: don't use mtls in gcb until b/492452834 is fixed#1769chandra-siri merged 5 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses potential instability in testing environments by precisely defining the version of the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request pins the google-auth dependency to a specific version, 2.48.0. While this ensures a specific version is used, it is a significant anti-pattern for a library package as it can easily create dependency conflicts for downstream users. The review contains a critical comment recommending to revert to a version range for google-auth, consistent with other dependencies in the project. Also, there is a small typo in the pull request title ('vesion' instead of 'version').
chore: don't use mtls in gcb until b/492452834 is fixed
Details in b/492452834