Skip to content

chore: don't use mtls in gcb until b/492452834 is fixed#1769

Merged
chandra-siri merged 5 commits intomainfrom
debug_failing_gcb
Mar 13, 2026
Merged

chore: don't use mtls in gcb until b/492452834 is fixed#1769
chandra-siri merged 5 commits intomainfrom
debug_failing_gcb

Conversation

@chandra-siri
Copy link
Collaborator

@chandra-siri chandra-siri commented Mar 13, 2026

chore: don't use mtls in gcb until b/492452834 is fixed

Details in b/492452834

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. labels Mar 13, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses potential instability in testing environments by precisely defining the version of the google-auth library. By pinning this dependency, the PR ensures that tests run against a known, stable version, thereby reducing the risk of failures caused by upstream library changes and improving the reliability of the test suite.

Highlights

  • Dependency Pinning: The google-auth dependency has been explicitly pinned to version 2.48.0 in setup.py. This change aims to ensure consistent behavior and prevent unexpected issues that might arise from future google-auth updates during testing.
Changelog
  • setup.py
    • Pinned the google-auth dependency to version 2.48.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request pins the google-auth dependency to a specific version, 2.48.0. While this ensures a specific version is used, it is a significant anti-pattern for a library package as it can easily create dependency conflicts for downstream users. The review contains a critical comment recommending to revert to a version range for google-auth, consistent with other dependencies in the project. Also, there is a small typo in the pull request title ('vesion' instead of 'version').

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 13, 2026
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Mar 13, 2026
@chandra-siri chandra-siri changed the title test: pin google-auth vesion to 2.48.0 chore: don't use mtls in gcb until b/ Mar 13, 2026
@chandra-siri chandra-siri changed the title chore: don't use mtls in gcb until b/ chore: don't use mtls in gcb until b/492452834 is fixed Mar 13, 2026
@chandra-siri chandra-siri marked this pull request as ready for review March 13, 2026 12:25
@chandra-siri chandra-siri requested review from a team as code owners March 13, 2026 12:25
@chandra-siri chandra-siri enabled auto-merge (squash) March 13, 2026 14:28
@chandra-siri chandra-siri merged commit 35b39b6 into main Mar 13, 2026
15 checks passed
@chandra-siri chandra-siri deleted the debug_failing_gcb branch March 13, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants